From: Raju Rangoju <rajur@chelsio.com>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, divy@chelsio.com,
jgarzik@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()
Date: Wed, 2 Dec 2020 17:14:26 +0530 [thread overview]
Message-ID: <20201202114424.GA13909@chelsio.com> (raw)
In-Reply-To: <1606902965-1646-1-git-send-email-zhangchangzhong@huawei.com>
On Wednesday, December 12/02/20, 2020 at 17:56:05 +0800, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
Acked-by: Raju Rangoju <rajur@chelsio.com>
> drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> index e18e9ce..1cc3c51 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> @@ -3175,6 +3175,7 @@ int t3_sge_alloc_qset(struct adapter *adapter, unsigned int id, int nports,
> GFP_KERNEL | __GFP_COMP);
> if (!avail) {
> CH_ALERT(adapter, "free list queue 0 initialization failed\n");
> + ret = -ENOMEM;
> goto err;
> }
> if (avail < q->fl[0].size)
> --
> 2.9.5
>
next prev parent reply other threads:[~2020-12-02 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 9:56 [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset() Zhang Changzhong
2020-12-02 11:44 ` Raju Rangoju [this message]
2020-12-03 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202114424.GA13909@chelsio.com \
--to=rajur@chelsio.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=jgarzik@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).