* [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()
@ 2020-12-02 9:56 Zhang Changzhong
2020-12-02 11:44 ` Raju Rangoju
2020-12-03 2:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Changzhong @ 2020-12-02 9:56 UTC (permalink / raw)
To: rajur, davem, kuba, divy, jgarzik; +Cc: netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index e18e9ce..1cc3c51 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -3175,6 +3175,7 @@ int t3_sge_alloc_qset(struct adapter *adapter, unsigned int id, int nports,
GFP_KERNEL | __GFP_COMP);
if (!avail) {
CH_ALERT(adapter, "free list queue 0 initialization failed\n");
+ ret = -ENOMEM;
goto err;
}
if (avail < q->fl[0].size)
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()
2020-12-02 9:56 [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset() Zhang Changzhong
@ 2020-12-02 11:44 ` Raju Rangoju
2020-12-03 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Raju Rangoju @ 2020-12-02 11:44 UTC (permalink / raw)
To: Zhang Changzhong; +Cc: davem, kuba, divy, jgarzik, netdev, linux-kernel
On Wednesday, December 12/02/20, 2020 at 17:56:05 +0800, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
Acked-by: Raju Rangoju <rajur@chelsio.com>
> drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> index e18e9ce..1cc3c51 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> @@ -3175,6 +3175,7 @@ int t3_sge_alloc_qset(struct adapter *adapter, unsigned int id, int nports,
> GFP_KERNEL | __GFP_COMP);
> if (!avail) {
> CH_ALERT(adapter, "free list queue 0 initialization failed\n");
> + ret = -ENOMEM;
> goto err;
> }
> if (avail < q->fl[0].size)
> --
> 2.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()
2020-12-02 9:56 [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset() Zhang Changzhong
2020-12-02 11:44 ` Raju Rangoju
@ 2020-12-03 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-03 2:20 UTC (permalink / raw)
To: Zhang Changzhong; +Cc: rajur, davem, kuba, divy, jgarzik, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 2 Dec 2020 17:56:05 +0800 you wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
>
> [...]
Here is the summary with links:
- [net] cxgb3: fix error return code in t3_sge_alloc_qset()
https://git.kernel.org/netdev/net/c/ff9924897f8b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-03 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 9:56 [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset() Zhang Changzhong
2020-12-02 11:44 ` Raju Rangoju
2020-12-03 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).