* [PATCH][next] wilc1000: remove redundant assignment to pointer vif
@ 2020-12-03 17:43 Colin King
2020-12-04 6:39 ` Ajay.Kathat
2020-12-07 16:34 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-12-03 17:43 UTC (permalink / raw)
To: Ajay Singh, Claudiu Beznea, Kalle Valo, David S . Miller,
Jakub Kicinski, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment to pointer vif is redundant as the assigned value
is never read, hence it can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index 993ea7c03429..c12f27be9f79 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -685,7 +685,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
if (!tqe_q[ac])
continue;
- vif = tqe_q[ac]->vif;
ac_exist = 1;
for (k = 0; (k < num_pkts_to_add[ac]) &&
(!max_size_over) && tqe_q[ac]; k++) {
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif
2020-12-03 17:43 [PATCH][next] wilc1000: remove redundant assignment to pointer vif Colin King
@ 2020-12-04 6:39 ` Ajay.Kathat
2020-12-07 16:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ajay.Kathat @ 2020-12-04 6:39 UTC (permalink / raw)
To: colin.king, Claudiu.Beznea, kvalo, davem, kuba, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
On 03/12/20 11:13 pm, Colin King wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks.
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
> drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
> index 993ea7c03429..c12f27be9f79 100644
> --- a/drivers/net/wireless/microchip/wilc1000/wlan.c
> +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
> @@ -685,7 +685,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
> if (!tqe_q[ac])
> continue;
>
> - vif = tqe_q[ac]->vif;
> ac_exist = 1;
> for (k = 0; (k < num_pkts_to_add[ac]) &&
> (!max_size_over) && tqe_q[ac]; k++) {
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif
2020-12-03 17:43 [PATCH][next] wilc1000: remove redundant assignment to pointer vif Colin King
2020-12-04 6:39 ` Ajay.Kathat
@ 2020-12-07 16:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-12-07 16:34 UTC (permalink / raw)
To: Colin King
Cc: Ajay Singh, Claudiu Beznea, David S . Miller, Jakub Kicinski,
linux-wireless, netdev, kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Patch applied to wireless-drivers-next.git, thanks.
9b0467ed9a7d wilc1000: remove redundant assignment to pointer vif
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201203174316.1071446-1-colin.king@canonical.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-07 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 17:43 [PATCH][next] wilc1000: remove redundant assignment to pointer vif Colin King
2020-12-04 6:39 ` Ajay.Kathat
2020-12-07 16:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).