* [PATCH] usb: typec: intel_pmc_mux: Use correct response message bits
@ 2020-12-03 22:08 Utkarsh Patel
2020-12-08 9:38 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Utkarsh Patel @ 2020-12-03 22:08 UTC (permalink / raw)
To: linux-kernel, linux-usb
Cc: heikki.krogerus, rajmohan.mani, azhar.shaikh, Utkarsh Patel
When Intel PMC Mux agent driver receives the response message from PMC, it
checks for the same response bits for all the mux states.
Corrected it by checking correct response message bits, Bit 8 & 9 for the
SAFE Mode and Alternate Modes and Bit 16 & 17 for the Connect and
Disconnect Modes.
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
drivers/usb/typec/mux/intel_pmc_mux.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
index aa3211f1c4c3..e58ae8a7fefb 100644
--- a/drivers/usb/typec/mux/intel_pmc_mux.c
+++ b/drivers/usb/typec/mux/intel_pmc_mux.c
@@ -176,6 +176,7 @@ static int hsl_orientation(struct pmc_usb_port *port)
static int pmc_usb_command(struct pmc_usb_port *port, u8 *msg, u32 len)
{
u8 response[4];
+ u8 status_res;
int ret;
/*
@@ -189,9 +190,13 @@ static int pmc_usb_command(struct pmc_usb_port *port, u8 *msg, u32 len)
if (ret)
return ret;
- if (response[2] & PMC_USB_RESP_STATUS_FAILURE) {
- if (response[2] & PMC_USB_RESP_STATUS_FATAL)
+ status_res = (msg[0] & 0xf) < PMC_USB_SAFE_MODE ?
+ response[2] : response[1];
+
+ if (status_res & PMC_USB_RESP_STATUS_FAILURE) {
+ if (status_res & PMC_USB_RESP_STATUS_FATAL)
return -EIO;
+
return -EBUSY;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: intel_pmc_mux: Use correct response message bits
2020-12-03 22:08 [PATCH] usb: typec: intel_pmc_mux: Use correct response message bits Utkarsh Patel
@ 2020-12-08 9:38 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2020-12-08 9:38 UTC (permalink / raw)
To: Utkarsh Patel; +Cc: linux-kernel, linux-usb, rajmohan.mani, azhar.shaikh
On Thu, Dec 03, 2020 at 02:08:13PM -0800, Utkarsh Patel wrote:
> When Intel PMC Mux agent driver receives the response message from PMC, it
> checks for the same response bits for all the mux states.
> Corrected it by checking correct response message bits, Bit 8 & 9 for the
> SAFE Mode and Alternate Modes and Bit 16 & 17 for the Connect and
> Disconnect Modes.
>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/intel_pmc_mux.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index aa3211f1c4c3..e58ae8a7fefb 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -176,6 +176,7 @@ static int hsl_orientation(struct pmc_usb_port *port)
> static int pmc_usb_command(struct pmc_usb_port *port, u8 *msg, u32 len)
> {
> u8 response[4];
> + u8 status_res;
> int ret;
>
> /*
> @@ -189,9 +190,13 @@ static int pmc_usb_command(struct pmc_usb_port *port, u8 *msg, u32 len)
> if (ret)
> return ret;
>
> - if (response[2] & PMC_USB_RESP_STATUS_FAILURE) {
> - if (response[2] & PMC_USB_RESP_STATUS_FATAL)
> + status_res = (msg[0] & 0xf) < PMC_USB_SAFE_MODE ?
> + response[2] : response[1];
> +
> + if (status_res & PMC_USB_RESP_STATUS_FAILURE) {
> + if (status_res & PMC_USB_RESP_STATUS_FATAL)
> return -EIO;
> +
> return -EBUSY;
> }
>
> --
> 2.17.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-08 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 22:08 [PATCH] usb: typec: intel_pmc_mux: Use correct response message bits Utkarsh Patel
2020-12-08 9:38 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).