* [PATCH] crypto: atmel-i2c - select CONFIG_BITREVERSE
@ 2020-12-03 23:20 Arnd Bergmann
2020-12-11 10:14 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-12-03 23:20 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Tudor-Dan Ambarus
Cc: Arnd Bergmann, Keerthy, linux-crypto, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The bitreverse helper is almost always built into the kernel,
but in a rare randconfig build it is possible to hit a case
in which it is a loadable module while the atmel-i2c driver
is built-in:
arm-linux-gnueabi-ld: drivers/crypto/atmel-i2c.o: in function `atmel_i2c_checksum':
atmel-i2c.c:(.text+0xa0): undefined reference to `byte_rev_table'
Add one more 'select' statement to prevent this.
Fixes: 11105693fa05 ("crypto: atmel-ecc - introduce Microchip / Atmel ECC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 6a02ab13835c..67a17644ce17 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -550,6 +550,7 @@ config CRYPTO_DEV_ATMEL_SHA
config CRYPTO_DEV_ATMEL_I2C
tristate
+ select BITREVERSE
config CRYPTO_DEV_ATMEL_ECC
tristate "Support for Microchip / Atmel ECC hw accelerator"
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: atmel-i2c - select CONFIG_BITREVERSE
2020-12-03 23:20 [PATCH] crypto: atmel-i2c - select CONFIG_BITREVERSE Arnd Bergmann
@ 2020-12-11 10:14 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-12-11 10:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Tudor-Dan Ambarus, Arnd Bergmann, Keerthy,
linux-crypto, linux-kernel
On Fri, Dec 04, 2020 at 12:20:04AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The bitreverse helper is almost always built into the kernel,
> but in a rare randconfig build it is possible to hit a case
> in which it is a loadable module while the atmel-i2c driver
> is built-in:
>
> arm-linux-gnueabi-ld: drivers/crypto/atmel-i2c.o: in function `atmel_i2c_checksum':
> atmel-i2c.c:(.text+0xa0): undefined reference to `byte_rev_table'
>
> Add one more 'select' statement to prevent this.
>
> Fixes: 11105693fa05 ("crypto: atmel-ecc - introduce Microchip / Atmel ECC driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-11 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 23:20 [PATCH] crypto: atmel-i2c - select CONFIG_BITREVERSE Arnd Bergmann
2020-12-11 10:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).