From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Andreas Färber" <afaerber@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller
Date: Sat, 5 Dec 2020 11:38:31 +0530 [thread overview]
Message-ID: <20201205060831.GA4068@thinkpad> (raw)
In-Reply-To: <20201129182421.GD696261@BV030612LT>
On Sun, Nov 29, 2020 at 08:24:21PM +0200, Cristian Ciocaltea wrote:
> On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote:
> > On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote:
> > > The DMA controller present on the Actions Semi S500 SoC is compatible
> > > with the S900 variant, so add it to the list of devices supported by
> > > the Actions Semi Owl DMA driver.
> > >
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> >
> > I hope that you have verified both Memcpy and Slave transfers...
>
> I have been using 'dmatest' module as documented in:
> https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html
>
> I tested all the available channels and could not find any signs of
> possible issues. Bellow is an excerpt from the kernel ring buffer:
>
> [ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0)
> [ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0)
> [ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0)
>
> Should I perform some additional tests?
>
Nope, this is sufficient. Since you have tested slave transfer with MMC driver,
running dmatest for memcpy is fine.
Thanks,
Mani
> Thanks,
> Cristi
>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Thanks,
> > Mani
> >
> > > ---
> > > drivers/dma/owl-dma.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> > > index 9fede32641e9..54e509de66e2 100644
> > > --- a/drivers/dma/owl-dma.c
> > > +++ b/drivers/dma/owl-dma.c
> > > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
> > > static const struct of_device_id owl_dma_match[] = {
> > > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
> > > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
> > > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
> > > { /* sentinel */ },
> > > };
> > > MODULE_DEVICE_TABLE(of, owl_dma_match);
> > > --
> > > 2.29.2
> > >
next prev parent reply other threads:[~2020-12-05 6:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 01/18] arm: dts: owl-s500: Add Clock Management Unit Cristian Ciocaltea
2020-11-28 7:22 ` Manivannan Sadhasivam
2020-11-29 17:55 ` Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 02/18] arm: dts: owl-s500: Set CMU clocks for UARTs Cristian Ciocaltea
2020-11-28 7:25 ` Manivannan Sadhasivam
2020-11-29 18:09 ` Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 03/18] arm: dts: owl-s500: Add Reset controller Cristian Ciocaltea
2020-11-28 7:25 ` Manivannan Sadhasivam
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2020-11-28 7:29 ` Manivannan Sadhasivam
2020-11-28 7:29 ` Manivannan Sadhasivam
2020-11-29 18:15 ` Cristian Ciocaltea
2020-12-07 22:11 ` Rob Herring
2020-12-07 22:56 ` Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Cristian Ciocaltea
2020-11-28 7:30 ` Manivannan Sadhasivam
2020-11-29 18:24 ` Cristian Ciocaltea
2020-12-05 6:08 ` Manivannan Sadhasivam [this message]
2020-11-19 23:56 ` [PATCH v2 06/18] arm: dts: owl-s500: Add " Cristian Ciocaltea
2020-11-28 7:31 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 07/18] arm: dts: owl-s500: Add pinctrl & GPIO support Cristian Ciocaltea
2020-11-28 7:32 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 08/18] dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2020-11-24 14:25 ` Ulf Hansson
2020-11-19 23:56 ` [PATCH v2 09/18] arm: dts: owl-s500: Add MMC support Cristian Ciocaltea
2020-11-24 14:25 ` Ulf Hansson
2020-11-24 14:53 ` Cristian Ciocaltea
2020-11-28 7:33 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
2020-12-07 22:12 ` Rob Herring
2020-12-07 22:58 ` Cristian Ciocaltea
2020-12-09 20:22 ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding Cristian Ciocaltea
2020-12-09 20:22 ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
2020-11-28 7:19 ` Manivannan Sadhasivam
2020-11-28 7:34 ` Manivannan Sadhasivam
2020-12-09 20:23 ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
2020-11-28 7:35 ` Manivannan Sadhasivam
2020-12-09 20:25 ` Wolfram Sang
2020-12-10 3:33 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 14/18] arm: dts: owl-s500: Add SIRQ controller Cristian Ciocaltea
2020-11-28 7:35 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 15/18] arm: dts: owl-s500-roseapplepi: Use UART clock from CMU Cristian Ciocaltea
2020-11-28 7:36 ` Manivannan Sadhasivam
2020-11-29 18:26 ` Cristian Ciocaltea
2020-11-19 23:56 ` [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support Cristian Ciocaltea
2020-11-28 7:38 ` Manivannan Sadhasivam
2020-11-29 18:35 ` Cristian Ciocaltea
2020-12-05 6:01 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 17/18] arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration Cristian Ciocaltea
2020-11-28 7:41 ` Manivannan Sadhasivam
2020-11-29 19:35 ` Cristian Ciocaltea
2020-11-19 23:56 ` [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch Cristian Ciocaltea
2020-11-28 7:43 ` Manivannan Sadhasivam
2020-11-29 19:48 ` Cristian Ciocaltea
2020-11-30 0:54 ` Andreas Färber
2020-12-05 5:54 ` Manivannan Sadhasivam
2020-12-28 10:43 ` Cristian Ciocaltea
2020-12-28 10:59 ` Manivannan Sadhasivam
2020-12-05 6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
2020-12-05 16:29 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205060831.GA4068@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=cristian.ciocaltea@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).