* [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
@ 2020-12-03 22:32 Arnd Bergmann
2020-12-05 1:42 ` Khalil Blaiech
2020-12-05 13:49 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-03 22:32 UTC (permalink / raw)
To: Vadim Pasternak, Wolfram Sang, Khalil Blaiech
Cc: Arnd Bergmann, Wolfram Sang, Jarkko Nikula, Andy Shevchenko,
Jean Delvare, linux-i2c, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
If this is not enabled, the interfaces used in this driver do not work:
drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
^
drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
^
drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
^
drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
^
Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index a97a9d058198..a49e0ed4a599 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -734,6 +734,7 @@ config I2C_LPC2K
config I2C_MLXBF
tristate "Mellanox BlueField I2C controller"
depends on MELLANOX_PLATFORM && ARM64
+ select I2C_SLAVE
help
Enabling this option will add I2C SMBus support for Mellanox BlueField
system.
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
2020-12-03 22:32 [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE Arnd Bergmann
@ 2020-12-05 1:42 ` Khalil Blaiech
2020-12-05 13:49 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Khalil Blaiech @ 2020-12-05 1:42 UTC (permalink / raw)
To: Arnd Bergmann, Vadim Pasternak, Wolfram Sang, Khalil Blaiech
Cc: Arnd Bergmann, Wolfram Sang, Jarkko Nikula, Andy Shevchenko,
Jean Delvare, linux-i2c, linux-kernel
> Subject: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> If this is not enabled, the interfaces used in this driver do not work:
>
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function
> 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier
> 'I2C_SLAVE_WRITE_REQUESTED'
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier
> 'I2C_SLAVE_WRITE_RECEIVED'
> ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier
> 'I2C_SLAVE_STOP'
> i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
> ^
>
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField
> SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index a97a9d058198..a49e0ed4a599 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -734,6 +734,7 @@ config I2C_LPC2K
> config I2C_MLXBF
> tristate "Mellanox BlueField I2C controller"
> depends on MELLANOX_PLATFORM && ARM64
> + select I2C_SLAVE
> help
> Enabling this option will add I2C SMBus support for Mellanox BlueField
> system.
> --
> 2.27.0
Thank you!
Acked-by: Khalil Blaiech <kblaiech@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
2020-12-03 22:32 [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE Arnd Bergmann
2020-12-05 1:42 ` Khalil Blaiech
@ 2020-12-05 13:49 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-12-05 13:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vadim Pasternak, Khalil Blaiech, Arnd Bergmann, Jarkko Nikula,
Andy Shevchenko, Jean Delvare, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Thu, Dec 03, 2020 at 11:32:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If this is not enabled, the interfaces used in this driver do not work:
>
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
> ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
> i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
> ^
>
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-05 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 22:32 [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE Arnd Bergmann
2020-12-05 1:42 ` Khalil Blaiech
2020-12-05 13:49 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).