* Re: [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning
[not found] <20201203012638.543321-1-ming.lei@redhat.com>
@ 2020-12-08 1:40 ` Ming Lei
0 siblings, 0 replies; only message in thread
From: Ming Lei @ 2020-12-08 1:40 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Qian Cai, Sumit Saxena,
John Garry, Kashyap Desai, Bart Van Assche, Hannes Reinecke,
linux-kernel
On Thu, Dec 03, 2020 at 09:26:35AM +0800, Ming Lei wrote:
> Hi,
>
> Qian reported there is hang during booting when shared host tagset is
> introduced on megaraid sas. Sumit reported the whole SCSI probe takes
> about ~45min in his test.
>
> Turns out it is caused by nr_hw_queues increased, especially commit
> b3c6a5997541("block: Fix a lockdep complaint triggered by request queue flushing")
> adds synchronize_rcu() for each hctx's release handler.
>
> Address the original lockdep false positive warning by simpler way, then
> long scsi probe can be avoided with lockdep enabled.
>
> V2:
> - add reviewed-by
> - adjust commit log of patch 3
>
> Ming Lei (3):
> blk-mq: add new API of blk_mq_hctx_set_fq_lock_class
> nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class
> Revert "block: Fix a lockdep complaint triggered by request queue
> flushing"
>
> block/blk-flush.c | 30 +++++++++++++++++++++++++-----
> block/blk.h | 1 -
> drivers/nvme/target/loop.c | 10 ++++++++++
> include/linux/blk-mq.h | 3 +++
> 4 files changed, 38 insertions(+), 6 deletions(-)
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Qian Cai <cai@redhat.com>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Hannes Reinecke <hare@suse.de>
> --
> 2.28.0
>
Hello Jens,
Ping...
--
Ming
^ permalink raw reply [flat|nested] only message in thread