[PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

[PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

[Zheng Yongjun]

Simplify the return expression.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index c9c2962ad49f..786d2fc4b403 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -1893,13 +1893,8 @@ void esw_offloads_unload_rep(struct mlx5_eswitch *esw, u16 vport_num)
 static int mlx5_esw_offloads_pair(struct mlx5_eswitch *esw,
 				  struct mlx5_eswitch *peer_esw)
 {
-	int err;
 
-	err = esw_add_fdb_peer_miss_rules(esw, peer_esw->dev);
-	if (err)
-		return err;
-
-	return 0;
+	return esw_add_fdb_peer_miss_rules(esw, peer_esw->dev);
 }
 
 static void mlx5_esw_offloads_unpair(struct mlx5_eswitch *esw)
-- 
2.22.0

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

[Jakub Kicinski]

On Tue, 8 Dec 2020 21:56:25 +0800 Zheng Yongjun wrote:
> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Please make sure to CC maintainers on your patches

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

[David Miller]

From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Tue, 8 Dec 2020 21:56:25 +0800

> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Applied.

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

[Saeed Mahameed]

On Tue, 2020-12-08 at 16:25 -0800, David Miller wrote:
> From: Zheng Yongjun <zhengyongjun3@huawei.com>
> Date: Tue, 8 Dec 2020 21:56:25 +0800
> 
> > Simplify the return expression.
> > 
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> 
> Applied.
> 

Hey Dave, it's great to have you back!

I still don't see this patch in net-next, i will take it to my tree
and submit it in my next pr.

Thanks,
Saeed.