From: kernel test robot <lkp@intel.com>
To: Qing Zhang <zhangqing@loongson.cn>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: kbuild-all@lists.01.org, linux-spi@vger.kernel.org,
Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, gaojuxin@loongson.cn
Subject: Re: [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support
Date: Tue, 8 Dec 2020 20:26:06 +0800 [thread overview]
Message-ID: <202012082045.oruMsnle-lkp@intel.com> (raw)
In-Reply-To: <1607413467-17698-1-git-send-email-zhangqing@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]
Hi Qing,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on spi/for-next]
[also build test WARNING on robh/for-next linus/master v5.10-rc7 next-20201207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qing-Zhang/spi-LS7A-Add-Loongson-LS7A-SPI-controller-driver-support/20201208-154822
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/6b2c3d42e1460dd3472a2c74d6a6c46d8693ce79
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Qing-Zhang/spi-LS7A-Add-Loongson-LS7A-SPI-controller-driver-support/20201208-154822
git checkout 6b2c3d42e1460dd3472a2c74d6a6c46d8693ce79
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/spi/spi-ls7a.c: In function 'ls7a_spi_write_read':
>> drivers/spi/spi-ls7a.c:162:19: warning: variable 'ls7a_spi' set but not used [-Wunused-but-set-variable]
162 | struct ls7a_spi *ls7a_spi;
| ^~~~~~~~
vim +/ls7a_spi +162 drivers/spi/spi-ls7a.c
158
159 static unsigned int ls7a_spi_write_read(struct spi_device *spi,
160 struct spi_transfer *xfer)
161 {
> 162 struct ls7a_spi *ls7a_spi;
163 unsigned int count;
164 const u8 *tx = xfer->tx_buf;
165 u8 *rx = xfer->rx_buf;
166
167 ls7a_spi = spi_master_get_devdata(spi->master);
168 count = xfer->len;
169
170 do {
171 if (ls7a_spi_write_read_8bit(spi, &tx, &rx, count) < 0)
172 goto out;
173 count--;
174 } while (count);
175
176 out:
177 return xfer->len - count;
178 }
179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77047 bytes --]
next prev parent reply other threads:[~2020-12-08 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 7:44 [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support Qing Zhang
2020-12-08 7:44 ` [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI Qing Zhang
2020-12-08 7:49 ` Jiaxun Yang
2020-12-08 8:40 ` Sergei Shtylyov
2020-12-08 10:47 ` zhangqing
2020-12-08 13:58 ` Mark Brown
2020-12-09 1:21 ` zhangqing
2020-12-08 14:48 ` Sergei Shtylyov
2020-12-09 1:16 ` zhangqing
2020-12-08 7:44 ` [PATCH v2 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A Qing Zhang
2020-12-08 8:15 ` Jiaxun Yang
2020-12-08 7:44 ` [PATCH v2 4/4] MIPS: Loongson: Enable Loongson LS7A SPI in loongson3_defconfig Qing Zhang
2020-12-08 12:26 ` kernel test robot [this message]
2020-12-08 13:56 ` [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support Mark Brown
2020-12-09 7:24 ` zhangqing
2020-12-09 11:59 ` Mark Brown
2020-12-08 21:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012082045.oruMsnle-lkp@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).