From: zhangqing <zhangqing@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-spi@vger.kernel.org, Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, gaojuxin@loongson.cn,
yangtiezhu@loongson.cn
Subject: Re: [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI
Date: Wed, 9 Dec 2020 09:21:21 +0800 [thread overview]
Message-ID: <8fef1345-86e9-c24f-c9bf-5d06848bc3ed@loongson.cn> (raw)
In-Reply-To: <20201208135852.GD6686@sirena.org.uk>
On 12/08/2020 09:58 PM, Mark Brown wrote:
> On Tue, Dec 08, 2020 at 06:47:10PM +0800, zhangqing wrote:
>> On 12/08/2020 04:40 PM, Sergei Shtylyov wrote:
>>>> +Required properties:
>>>> +- #interrupts: No hardware interrupt.
>>> You say it's a required prop, yet yuoe example doesn't have it...
>> I want to emphasize here that LS7A SPI has no hardware interrupts,
>> and DT is not actually used.
> There is no need to do this, and documenting the property as required
> just makes things confusing here.
Thanks for your suggestion,
I will remove the #interrupt attribute in the third edition.
Thanks,
-Qing
>
>
next prev parent reply other threads:[~2020-12-09 1:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 7:44 [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support Qing Zhang
2020-12-08 7:44 ` [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI Qing Zhang
2020-12-08 7:49 ` Jiaxun Yang
2020-12-08 8:40 ` Sergei Shtylyov
2020-12-08 10:47 ` zhangqing
2020-12-08 13:58 ` Mark Brown
2020-12-09 1:21 ` zhangqing [this message]
2020-12-08 14:48 ` Sergei Shtylyov
2020-12-09 1:16 ` zhangqing
2020-12-08 7:44 ` [PATCH v2 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A Qing Zhang
2020-12-08 8:15 ` Jiaxun Yang
2020-12-08 7:44 ` [PATCH v2 4/4] MIPS: Loongson: Enable Loongson LS7A SPI in loongson3_defconfig Qing Zhang
2020-12-08 12:26 ` [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support kernel test robot
2020-12-08 13:56 ` Mark Brown
2020-12-09 7:24 ` zhangqing
2020-12-09 11:59 ` Mark Brown
2020-12-08 21:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fef1345-86e9-c24f-c9bf-5d06848bc3ed@loongson.cn \
--to=zhangqing@loongson.cn \
--cc=broonie@kernel.org \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).