* [PATCH v4 0/1] Thunderbolt3/USB4 cable rounded and active cable plug link training support
@ 2020-12-09 4:24 Utkarsh Patel
2020-12-09 4:24 ` [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4 Utkarsh Patel
0 siblings, 1 reply; 3+ messages in thread
From: Utkarsh Patel @ 2020-12-09 4:24 UTC (permalink / raw)
To: linux-kernel, linux-usb
Cc: heikki.krogerus, pmalani, enric.balletbo, rajmohan.mani,
azhar.shaikh, Utkarsh Patel
This patch series adds the support for Thunderbolt3/USB4 rounded and
non-rounded frequencies cables and fixes the active cable plug link
training support
Changes in v4:
- Removed patches 1/4, 2/4 and 4/4 as the implementation of tbt_mode_vdo
from Enter_USB message is not needed.
- With that there are no changes in active cable plug link training
support.
- Previous version can be found here:
https://www.spinics.net/lists/linux-usb/msg204914.html
* Patch 1: "usb: typec: intel_pmc_mux: Configure cable generation value
for USB4"
- Removed usage of tbt_mode_vdo since data rates should always be rounded
in the case of USB4.
- Updated commit message to reflect the change.
Changes in v3:
- First four patches of this series have been queued by Greg to usb-testing
branch. https://www.spinics.net/lists/linux-usb/msg204880.html
- Changed commit message and description in header file in patch 1/4.
- Added a check for Cable's TBT support in patch 2/4
- Moved TBT_CABLE_ROUNDED_SUPPORT assignment to same line in patch 3/4.
- Rebased and added Reviewed-by tag in patch 4/4.
Changes in v2:
- Removed the fixes tag as there is no functional implication from patches
1/8, 2/8 and 4/8.
Utkarsh Patel (1):
usb: typec: intel_pmc_mux: Configure cable generation value for USB4
drivers/usb/typec/mux/intel_pmc_mux.c | 5 +++++
1 file changed, 5 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4
2020-12-09 4:24 [PATCH v4 0/1] Thunderbolt3/USB4 cable rounded and active cable plug link training support Utkarsh Patel
@ 2020-12-09 4:24 ` Utkarsh Patel
2020-12-10 11:50 ` Heikki Krogerus
0 siblings, 1 reply; 3+ messages in thread
From: Utkarsh Patel @ 2020-12-09 4:24 UTC (permalink / raw)
To: linux-kernel, linux-usb
Cc: heikki.krogerus, pmalani, enric.balletbo, rajmohan.mani,
azhar.shaikh, Utkarsh Patel
USB4 specification chapter 3 indicates that cable data rates have to be
rounded for USB4 device to operate as USB4.
With that configure cable generation value to use rounded data rates for
USB4.
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
Changes in v4:
- Removed usage of tbt_mode_vdo since data rates should always be rounded
in the case of USB4.
- Updated commit message to reflect the change.
Changes in v3:
- Moved TBT_CABLE_ROUNDED_SUPPORT assignment to the same line.
Changes in v2:
- No change.
---
drivers/usb/typec/mux/intel_pmc_mux.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
index e58ae8a7fefb..cf37a59ce130 100644
--- a/drivers/usb/typec/mux/intel_pmc_mux.c
+++ b/drivers/usb/typec/mux/intel_pmc_mux.c
@@ -327,6 +327,11 @@ pmc_usb_mux_usb4(struct pmc_usb_port *port, struct typec_mux_state *state)
fallthrough;
default:
req.mode_data |= PMC_USB_ALTMODE_ACTIVE_CABLE;
+
+ /* Configure data rate to rounded in the case of Active TBT3
+ * and USB4 cables.
+ */
+ req.mode_data |= PMC_USB_ALTMODE_TBT_GEN(1);
break;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4
2020-12-09 4:24 ` [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4 Utkarsh Patel
@ 2020-12-10 11:50 ` Heikki Krogerus
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2020-12-10 11:50 UTC (permalink / raw)
To: Utkarsh Patel
Cc: linux-kernel, linux-usb, pmalani, enric.balletbo, rajmohan.mani,
azhar.shaikh
On Tue, Dec 08, 2020 at 08:24:08PM -0800, Utkarsh Patel wrote:
> USB4 specification chapter 3 indicates that cable data rates have to be
> rounded for USB4 device to operate as USB4.
> With that configure cable generation value to use rounded data rates for
> USB4.
>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes in v4:
> - Removed usage of tbt_mode_vdo since data rates should always be rounded
> in the case of USB4.
> - Updated commit message to reflect the change.
>
> Changes in v3:
> - Moved TBT_CABLE_ROUNDED_SUPPORT assignment to the same line.
>
> Changes in v2:
> - No change.
> ---
> drivers/usb/typec/mux/intel_pmc_mux.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index e58ae8a7fefb..cf37a59ce130 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -327,6 +327,11 @@ pmc_usb_mux_usb4(struct pmc_usb_port *port, struct typec_mux_state *state)
> fallthrough;
> default:
> req.mode_data |= PMC_USB_ALTMODE_ACTIVE_CABLE;
> +
> + /* Configure data rate to rounded in the case of Active TBT3
> + * and USB4 cables.
> + */
> + req.mode_data |= PMC_USB_ALTMODE_TBT_GEN(1);
> break;
> }
>
> --
> 2.17.1
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-10 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 4:24 [PATCH v4 0/1] Thunderbolt3/USB4 cable rounded and active cable plug link training support Utkarsh Patel
2020-12-09 4:24 ` [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4 Utkarsh Patel
2020-12-10 11:50 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).