* [PATCH 0/1] scsi: ufs-mediatek: use correct path to fix compiling error
@ 2020-12-09 6:31 Zhen Lei
2020-12-09 6:31 ` [PATCH 1/1] " Zhen Lei
0 siblings, 1 reply; 4+ messages in thread
From: Zhen Lei @ 2020-12-09 6:31 UTC (permalink / raw)
To: Stanley Chu, Alim Akhtar, Avri Altman, James E . J . Bottomley,
Martin K . Petersen, Matthias Brugger, linux-scsi,
linux-mediatek, linux-arm-kernel, linux-kernel
Cc: Zhen Lei
This patch is based on the latest linux-next code. So the Fixes commit-id
maybe changed when it merged int v5.11-rc1.
Zhen Lei (1):
scsi: ufs-mediatek: use correct path to fix compiling error
drivers/scsi/ufs/ufs-mediatek-trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.26.0.106.g9fadedd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] scsi: ufs-mediatek: use correct path to fix compiling error
2020-12-09 6:31 [PATCH 0/1] scsi: ufs-mediatek: use correct path to fix compiling error Zhen Lei
@ 2020-12-09 6:31 ` Zhen Lei
2020-12-09 6:48 ` Stanley Chu
2020-12-09 17:01 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Zhen Lei @ 2020-12-09 6:31 UTC (permalink / raw)
To: Stanley Chu, Alim Akhtar, Avri Altman, James E . J . Bottomley,
Martin K . Petersen, Matthias Brugger, linux-scsi,
linux-mediatek, linux-arm-kernel, linux-kernel
Cc: Zhen Lei
When the kernel is compiled with allmodconfig, the following error is
reported:
In file included from drivers/scsi/ufs/ufs-mediatek-trace.h:36:0,
from drivers/scsi/ufs/ufs-mediatek.c:28:
./include/trace/define_trace.h:95:42: fatal error: ./ufs-mediatek-trace.h: No such file or directory
#include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
The comment in include/trace/define_trace.h specifies that:
TRACE_INCLUDE_PATH: Note, the path is relative to define_trace.h, not the
file including it. Full path names for out of tree modules must be used.
So without "CFLAGS_ufs-mediatek.o := -I$(src)", the current directory "."
is "include/trace/", the relative path of ufs-mediatek-trace.h is
"../../drivers/scsi/ufs/".
Fixes: ca1bb061d644 ("scsi: ufs-mediatek: Introduce event_notify implementation")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/scsi/ufs/ufs-mediatek-trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek-trace.h b/drivers/scsi/ufs/ufs-mediatek-trace.h
index fd6f84c1b4e2256..895e82ea6ece551 100644
--- a/drivers/scsi/ufs/ufs-mediatek-trace.h
+++ b/drivers/scsi/ufs/ufs-mediatek-trace.h
@@ -31,6 +31,6 @@ TRACE_EVENT(ufs_mtk_event,
#undef TRACE_INCLUDE_PATH
#undef TRACE_INCLUDE_FILE
-#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_PATH ../../drivers/scsi/ufs/
#define TRACE_INCLUDE_FILE ufs-mediatek-trace
#include <trace/define_trace.h>
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] scsi: ufs-mediatek: use correct path to fix compiling error
2020-12-09 6:31 ` [PATCH 1/1] " Zhen Lei
@ 2020-12-09 6:48 ` Stanley Chu
2020-12-09 17:01 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Stanley Chu @ 2020-12-09 6:48 UTC (permalink / raw)
To: Zhen Lei
Cc: Alim Akhtar, Avri Altman, James E . J . Bottomley,
Martin K . Petersen, Matthias Brugger, linux-scsi,
linux-mediatek, linux-arm-kernel, linux-kernel
Hi Zhen,
On Wed, 2020-12-09 at 14:31 +0800, Zhen Lei wrote:
> When the kernel is compiled with allmodconfig, the following error is
> reported:
> In file included from drivers/scsi/ufs/ufs-mediatek-trace.h:36:0,
> from drivers/scsi/ufs/ufs-mediatek.c:28:
> ./include/trace/define_trace.h:95:42: fatal error: ./ufs-mediatek-trace.h: No such file or directory
> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>
> The comment in include/trace/define_trace.h specifies that:
> TRACE_INCLUDE_PATH: Note, the path is relative to define_trace.h, not the
> file including it. Full path names for out of tree modules must be used.
>
> So without "CFLAGS_ufs-mediatek.o := -I$(src)", the current directory "."
> is "include/trace/", the relative path of ufs-mediatek-trace.h is
> "../../drivers/scsi/ufs/".
>
> Fixes: ca1bb061d644 ("scsi: ufs-mediatek: Introduce event_notify implementation")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/scsi/ufs/ufs-mediatek-trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek-trace.h b/drivers/scsi/ufs/ufs-mediatek-trace.h
> index fd6f84c1b4e2256..895e82ea6ece551 100644
> --- a/drivers/scsi/ufs/ufs-mediatek-trace.h
> +++ b/drivers/scsi/ufs/ufs-mediatek-trace.h
> @@ -31,6 +31,6 @@ TRACE_EVENT(ufs_mtk_event,
>
> #undef TRACE_INCLUDE_PATH
> #undef TRACE_INCLUDE_FILE
> -#define TRACE_INCLUDE_PATH .
> +#define TRACE_INCLUDE_PATH ../../drivers/scsi/ufs/
> #define TRACE_INCLUDE_FILE ufs-mediatek-trace
> #include <trace/define_trace.h>
Thanks for this fix.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] scsi: ufs-mediatek: use correct path to fix compiling error
2020-12-09 6:31 ` [PATCH 1/1] " Zhen Lei
2020-12-09 6:48 ` Stanley Chu
@ 2020-12-09 17:01 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-12-09 17:01 UTC (permalink / raw)
To: Zhen Lei
Cc: Stanley Chu, Alim Akhtar, Avri Altman, James E . J . Bottomley,
Martin K . Petersen, Matthias Brugger, linux-scsi,
linux-mediatek, linux-arm-kernel, linux-kernel
Zhen,
> So without "CFLAGS_ufs-mediatek.o := -I$(src)", the current directory "."
> is "include/trace/", the relative path of ufs-mediatek-trace.h is
> "../../drivers/scsi/ufs/".
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-09 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 6:31 [PATCH 0/1] scsi: ufs-mediatek: use correct path to fix compiling error Zhen Lei
2020-12-09 6:31 ` [PATCH 1/1] " Zhen Lei
2020-12-09 6:48 ` Stanley Chu
2020-12-09 17:01 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).