* [PATCH 1/1] dt-bindings: i2c: dw: don't set "#address-cells" and "#size-cells" as required
@ 2020-12-11 12:39 Zhen Lei
0 siblings, 0 replies; only message in thread
From: Zhen Lei @ 2020-12-11 12:39 UTC (permalink / raw)
To: Rob Herring, Serge Semin, Wolfram Sang, linux-i2c, devicetree,
linux-kernel
Cc: Zhen Lei
"#address-cells" and "#size-cells" is required only when the I2C
controller has subnodes. Of the four examples given in this document, only
the third has a child node "eeprom@64".
Ohterwise, false positives similar to the following are reported:
/root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
i2c@f7100000: '#address-cells' is a required property
/root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
i2c@f7100000: '#size-cells' is a required property
In fact, the predecessor of this document: i2c-designware.txt, does not
list "#address-cells" and "#size-cells" as "Required properties" also.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 8 --------
1 file changed, 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
index 4f746bef23742e9..c22b66b6219eaa3 100644
--- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
@@ -101,8 +101,6 @@ unevaluatedProperties: false
required:
- compatible
- reg
- - "#address-cells"
- - "#size-cells"
- interrupts
examples:
@@ -110,8 +108,6 @@ examples:
i2c@f0000 {
compatible = "snps,designware-i2c";
reg = <0xf0000 0x1000>;
- #address-cells = <1>;
- #size-cells = <0>;
interrupts = <11>;
clock-frequency = <400000>;
};
@@ -119,8 +115,6 @@ examples:
i2c@1120000 {
compatible = "snps,designware-i2c";
reg = <0x1120000 0x1000>;
- #address-cells = <1>;
- #size-cells = <0>;
interrupts = <12 1>;
clock-frequency = <400000>;
i2c-sda-hold-time-ns = <300>;
@@ -148,8 +142,6 @@ examples:
reg = <0x100400 0x100>, <0x198 0x8>;
pinctrl-0 = <&i2c_pins>;
pinctrl-names = "default";
- #address-cells = <1>;
- #size-cells = <0>;
interrupts = <8>;
clocks = <&ahb_clk>;
};
--
1.8.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-11 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 12:39 [PATCH 1/1] dt-bindings: i2c: dw: don't set "#address-cells" and "#size-cells" as required Zhen Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).