linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vivek Aknurwar <viveka@codeaurora.org>,
	Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jeevan Shriram <jshriram@codeaurora.org>
Subject: Re: [PATCH v2 5/5] clk: qcom: gcc: Add clock driver for SM8350
Date: Mon, 14 Dec 2020 10:10:30 +0530	[thread overview]
Message-ID: <20201214044030.GD8403@vkoul-mobl> (raw)
In-Reply-To: <a6cc3d1e-4a72-63be-bf1c-5d560ecef9aa@codeaurora.org>

Hi Taniya,

On 13-12-20, 14:00, Taniya Das wrote:
> 
> 
> On 12/11/2020 12:40 PM, Stephen Boyd wrote:
> > Quoting Vinod Koul (2020-12-10 21:43:49)
> > > On 10-12-20, 12:43, Stephen Boyd wrote:
> > > > > +static struct clk_branch gcc_camera_ahb_clk = {
> > > > > +       .halt_reg = 0x26004,
> > > > > +       .halt_check = BRANCH_HALT_DELAY,
> > > > > +       .hwcg_reg = 0x26004,
> > > > > +       .hwcg_bit = 1,
> > > > > +       .clkr = {
> > > > > +               .enable_reg = 0x26004,
> > > > > +               .enable_mask = BIT(0),
> > > > > +               .hw.init = &(struct clk_init_data){
> > > > > +                       .name = "gcc_camera_ahb_clk",
> > > > > +                       .flags = CLK_IS_CRITICAL,
> > > > 
> > > > Why is it critical? Can we just enable it in driver probe and stop
> > > > modeling it as a clk?
> > > 
> > > it does not have a parent we control, yeah it would make sense to do
> > > that. Tanya do you folks agree ..?
> > > 
> > 
> > Maybe it is needed for camera clk controller? Have to check other SoCs
> > and see if they're using it.
> > 
> 
> Yes, they would have to be left enabled.
> 
> Vinod, could you please move them to probe, similar to kona/sc7180 where all
> the CRITICALs clocks are left enabled?

Thanks for the pointer, will do

Thanks
-- 
~Vinod

      reply	other threads:[~2020-12-14  4:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  6:46 [PATCH v2 0/5] Add clock drivers for SM8350 Vinod Koul
2020-12-08  6:46 ` [PATCH v2 1/5] dt-bindings: clock: Add RPMHCC bindings " Vinod Koul
2020-12-10  3:59   ` Rob Herring
2020-12-10 20:44   ` Stephen Boyd
2020-12-08  6:46 ` [PATCH v2 2/5] clk: qcom: rpmh: add support for SM8350 rpmh clocks Vinod Koul
2020-12-10 20:48   ` Stephen Boyd
2020-12-08  6:47 ` [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings Vinod Koul
2020-12-10  4:01   ` Rob Herring
2020-12-10  6:11     ` Vinod Koul
2020-12-10 20:31       ` Stephen Boyd
2020-12-11  4:29         ` Vinod Koul
2020-12-08  6:47 ` [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL Vinod Koul
2020-12-10 20:36   ` Stephen Boyd
2020-12-11  5:02     ` Vinod Koul
2020-12-11  7:09       ` Stephen Boyd
2020-12-08  6:47 ` [PATCH v2 5/5] clk: qcom: gcc: Add clock driver for SM8350 Vinod Koul
2020-12-10 20:43   ` Stephen Boyd
2020-12-11  5:43     ` Vinod Koul
2020-12-11  7:10       ` Stephen Boyd
2020-12-13  8:30         ` Taniya Das
2020-12-14  4:40           ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214044030.GD8403@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jshriram@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tdas@codeaurora.org \
    --cc=viveka@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).