From: Stephen Boyd <sboyd@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vivek Aknurwar <viveka@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jeevan Shriram <jshriram@codeaurora.org>
Subject: Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL
Date: Thu, 10 Dec 2020 23:09:18 -0800 [thread overview]
Message-ID: <160767055805.1580929.10874243981268932091@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20201211050257.GR8403@vkoul-mobl>
Quoting Vinod Koul (2020-12-10 21:02:57)
> On 10-12-20, 12:36, Stephen Boyd wrote:
> > > +
> > > + return regmap_update_bits(pll->clkr.regmap, PLL_USER_CTL(pll),
> > > + (BIT(pll->width) - 1) << pll->post_div_shift,
> >
> > Use GENMASK?
>
> Looks like this can be:
> GENMASK(pll->width + pll->post_div_shift - 1, pll->post_div_shift)
>
> Not sure which one you like :)
Preferably a local u32 mask = GENMASK(...)
next prev parent reply other threads:[~2020-12-11 7:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 6:46 [PATCH v2 0/5] Add clock drivers for SM8350 Vinod Koul
2020-12-08 6:46 ` [PATCH v2 1/5] dt-bindings: clock: Add RPMHCC bindings " Vinod Koul
2020-12-10 3:59 ` Rob Herring
2020-12-10 20:44 ` Stephen Boyd
2020-12-08 6:46 ` [PATCH v2 2/5] clk: qcom: rpmh: add support for SM8350 rpmh clocks Vinod Koul
2020-12-10 20:48 ` Stephen Boyd
2020-12-08 6:47 ` [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings Vinod Koul
2020-12-10 4:01 ` Rob Herring
2020-12-10 6:11 ` Vinod Koul
2020-12-10 20:31 ` Stephen Boyd
2020-12-11 4:29 ` Vinod Koul
2020-12-08 6:47 ` [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL Vinod Koul
2020-12-10 20:36 ` Stephen Boyd
2020-12-11 5:02 ` Vinod Koul
2020-12-11 7:09 ` Stephen Boyd [this message]
2020-12-08 6:47 ` [PATCH v2 5/5] clk: qcom: gcc: Add clock driver for SM8350 Vinod Koul
2020-12-10 20:43 ` Stephen Boyd
2020-12-11 5:43 ` Vinod Koul
2020-12-11 7:10 ` Stephen Boyd
2020-12-13 8:30 ` Taniya Das
2020-12-14 4:40 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160767055805.1580929.10874243981268932091@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jshriram@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
--cc=viveka@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).