* [PATCH -next] drm: omapdrm: Delete useless kfree code
@ 2020-12-14 13:46 Zheng Yongjun
2020-12-15 15:19 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-14 13:46 UTC (permalink / raw)
To: tomi.valkeinen, airlied, daniel, dri-devel, linux-kernel; +Cc: Zheng Yongjun
The parameter of kfree function is NULL, so kfree code is useless, delete it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/gpu/drm/omapdrm/tcm-sita.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c
index 817be3c41863..af59e9c03917 100644
--- a/drivers/gpu/drm/omapdrm/tcm-sita.c
+++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
@@ -254,6 +254,5 @@ struct tcm *sita_init(u16 width, u16 height)
return tcm;
error:
- kfree(tcm);
return NULL;
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: omapdrm: Delete useless kfree code
2020-12-14 13:46 [PATCH -next] drm: omapdrm: Delete useless kfree code Zheng Yongjun
@ 2020-12-15 15:19 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2020-12-15 15:19 UTC (permalink / raw)
To: Zheng Yongjun, airlied, daniel, dri-devel, linux-kernel
On 14/12/2020 15:46, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/gpu/drm/omapdrm/tcm-sita.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c
> index 817be3c41863..af59e9c03917 100644
> --- a/drivers/gpu/drm/omapdrm/tcm-sita.c
> +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
> @@ -254,6 +254,5 @@ struct tcm *sita_init(u16 width, u16 height)
> return tcm;
>
> error:
> - kfree(tcm);
> return NULL;
> }
Thanks, I'll merge this.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-15 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 13:46 [PATCH -next] drm: omapdrm: Delete useless kfree code Zheng Yongjun
2020-12-15 15:19 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).