From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Philipp Gerlesberger'" <Philipp.Gerlesberger@fau.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"ij72uhux@stud.informatik.uni-erlangen.de"
<ij72uhux@stud.informatik.uni-erlangen.de>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS
Date: Mon, 14 Dec 2020 17:16:44 +0300 [thread overview]
Message-ID: <20201214141644.GF2809@kadam> (raw)
In-Reply-To: <4eef67d66b0b48feba474906431daa30@AcuMS.aculab.com>
On Mon, Dec 14, 2020 at 11:53:04AM +0000, David Laight wrote:
> From: Philipp Gerlesberger
> > Sent: 14 December 2020 11:02
> >
> > Logical continuations should be on the previous line
> >
> > Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> > Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
> > ---
> > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > index 2f1c2df59f71..7d44070c7114 100644
> > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > @@ -24,8 +24,8 @@
> > *****************************************************************************/
> > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc)
> > {
> > - if (NULL == qhandle || NULL == desc
> > - || NULL == desc->cb_elems || NULL == desc->cb_desc) {
> > + if (NULL == qhandle || NULL == desc ||
> > + NULL == desc->cb_elems || NULL == desc->cb_desc) {
> > /* Invalid parameters, return error*/
Delete this comment as well. It's pointless. (And the curly braces).
> > return -EINVAL;
>
regards,
dan carpenter
next prev parent reply other threads:[~2020-12-14 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:01 [PATCH v2 00/12] media: atomisp: Codingstyle Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 01/12] media: atomisp: Convert comments to C99 initializers Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 02/12] media: atomisp: Fix Block Comments Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 04/12] media: atomisp: Fix OPEN_ENDED_LINE Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 05/12] media: atomisp: Fix overlong line Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 06/12] media: atomisp: Remove defines Philipp Gerlesberger
2021-03-23 13:12 ` Mauro Carvalho Chehab
2020-12-14 11:01 ` [PATCH v2 07/12] media: atomisp: Fix funciton decleration Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 08/12] media: atomisp: Delete braces Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
2020-12-14 11:53 ` David Laight
2020-12-14 14:16 ` Dan Carpenter [this message]
2021-03-23 13:16 ` Mauro Carvalho Chehab
2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-14 11:03 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214141644.GF2809@kadam \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@ACULAB.COM \
--cc=Philipp.Gerlesberger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ij72uhux@stud.informatik.uni-erlangen.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).