[PATCH v1] media: ipu3-cio2: Build only for x86

* [PATCH v1] media: ipu3-cio2: Build only for x86
@ 2020-12-14 15:28 Andy Shevchenko
  0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2020-12-14 15:28 UTC (permalink / raw)
  To: Yong Zhi, Bingbu Cao, linux-media, Tianshu Qiu, linux-kernel,
	Mauro Carvalho Chehab
  Cc: Andy Shevchenko, kernel test robot, Sakari Ailus

According to the original code in the driver it was never assumed to work
with big page sizes: unsigned short type followed by PAGE_SHIFT and PAGE_MASK
which may be different on non-x86 architectures.

Recently LKP found an issue on non-x86 architectures due to above mentioned
limitations. Since Sakari acknowledges that it's not really useful to be able
to compile this elsewhere, mark it x86 only.

Fixes: a31d19f88932 ("media: ipu3: allow building it with COMPILE_TEST on non-x86 archs")
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/pci/intel/ipu3/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/pci/intel/ipu3/Kconfig b/drivers/media/pci/intel/ipu3/Kconfig
index 82d7f17e6a02..7a805201034b 100644
--- a/drivers/media/pci/intel/ipu3/Kconfig
+++ b/drivers/media/pci/intel/ipu3/Kconfig
@@ -2,7 +2,8 @@
 config VIDEO_IPU3_CIO2
 	tristate "Intel ipu3-cio2 driver"
 	depends on VIDEO_V4L2 && PCI
-	depends on (X86 && ACPI) || COMPILE_TEST
+	depends on ACPI || COMPILE_TEST
+	depends on X86
 	select MEDIA_CONTROLLER
 	select VIDEO_V4L2_SUBDEV_API
 	select V4L2_FWNODE
-- 
2.29.2


^ permalink raw reply related	[flat|nested] only message in thread