* [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable
@ 2020-11-07 6:26 xiakaixu1987
2020-11-07 7:36 ` Greg Kurz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: xiakaixu1987 @ 2020-11-07 6:26 UTC (permalink / raw)
To: paulus; +Cc: kvm-ppc, linuxppc-dev, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
Fix the following coccinelle warnings:
./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool variable
./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to bool variable
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
arch/powerpc/kvm/book3s_xics.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
index 5fee5a11550d..303e3cb096db 100644
--- a/arch/powerpc/kvm/book3s_xics.c
+++ b/arch/powerpc/kvm/book3s_xics.c
@@ -473,7 +473,7 @@ static void icp_deliver_irq(struct kvmppc_xics *xics, struct kvmppc_icp *icp,
arch_spin_unlock(&ics->lock);
local_irq_restore(flags);
new_irq = reject;
- check_resend = 0;
+ check_resend = false;
goto again;
}
} else {
@@ -501,7 +501,7 @@ static void icp_deliver_irq(struct kvmppc_xics *xics, struct kvmppc_icp *icp,
state->resend = 0;
arch_spin_unlock(&ics->lock);
local_irq_restore(flags);
- check_resend = 0;
+ check_resend = false;
goto again;
}
}
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable
2020-11-07 6:26 [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable xiakaixu1987
@ 2020-11-07 7:36 ` Greg Kurz
2020-12-15 2:14 ` Paul Mackerras
2020-12-21 11:03 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Greg Kurz @ 2020-11-07 7:36 UTC (permalink / raw)
To: xiakaixu1987; +Cc: paulus, kvm-ppc, linuxppc-dev, linux-kernel, Kaixu Xia
On Sat, 7 Nov 2020 14:26:22 +0800
xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccinelle warnings:
>
> ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool variable
> ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> arch/powerpc/kvm/book3s_xics.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
> index 5fee5a11550d..303e3cb096db 100644
> --- a/arch/powerpc/kvm/book3s_xics.c
> +++ b/arch/powerpc/kvm/book3s_xics.c
> @@ -473,7 +473,7 @@ static void icp_deliver_irq(struct kvmppc_xics *xics, struct kvmppc_icp *icp,
> arch_spin_unlock(&ics->lock);
> local_irq_restore(flags);
> new_irq = reject;
> - check_resend = 0;
> + check_resend = false;
> goto again;
> }
> } else {
> @@ -501,7 +501,7 @@ static void icp_deliver_irq(struct kvmppc_xics *xics, struct kvmppc_icp *icp,
> state->resend = 0;
> arch_spin_unlock(&ics->lock);
> local_irq_restore(flags);
> - check_resend = 0;
> + check_resend = false;
> goto again;
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable
2020-11-07 6:26 [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable xiakaixu1987
2020-11-07 7:36 ` Greg Kurz
@ 2020-12-15 2:14 ` Paul Mackerras
2020-12-21 11:03 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Paul Mackerras @ 2020-12-15 2:14 UTC (permalink / raw)
To: xiakaixu1987; +Cc: kvm-ppc, linuxppc-dev, linux-kernel, Kaixu Xia
On Sat, Nov 07, 2020 at 02:26:22PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccinelle warnings:
>
> ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool variable
> ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Acked-by: Paul Mackerras <paulus@ozlabs.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable
2020-11-07 6:26 [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable xiakaixu1987
2020-11-07 7:36 ` Greg Kurz
2020-12-15 2:14 ` Paul Mackerras
@ 2020-12-21 11:03 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2020-12-21 11:03 UTC (permalink / raw)
To: xiakaixu1987, paulus; +Cc: kvm-ppc, linuxppc-dev, Kaixu Xia, linux-kernel
On Sat, 7 Nov 2020 14:26:22 +0800, xiakaixu1987@gmail.com wrote:
> Fix the following coccinelle warnings:
>
> ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool variable
> ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to bool variable
Applied to powerpc/next.
[1/1] KVM: PPC: Book3S: Assign boolean values to a bool variable
https://git.kernel.org/powerpc/c/13751f8747519fe3bdc738fa6d802fbd94a85ac4
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable
@ 2021-01-25 7:59 Jiapeng Zhong
0 siblings, 0 replies; 5+ messages in thread
From: Jiapeng Zhong @ 2021-01-25 7:59 UTC (permalink / raw)
To: paulus; +Cc: mpe, benh, kvm-ppc, linuxppc-dev, linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./arch/powerpc/kvm/book3s_hv_rm_xics.c:381:3-15: WARNING: Assignment of
0/1 to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
arch/powerpc/kvm/book3s_hv_rm_xics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_hv_rm_xics.c b/arch/powerpc/kvm/book3s_hv_rm_xics.c
index c2c9c73..68e509d 100644
--- a/arch/powerpc/kvm/book3s_hv_rm_xics.c
+++ b/arch/powerpc/kvm/book3s_hv_rm_xics.c
@@ -378,7 +378,7 @@ static void icp_rm_deliver_irq(struct kvmppc_xics *xics, struct kvmppc_icp *icp,
arch_spin_unlock(&ics->lock);
icp->n_reject++;
new_irq = reject;
- check_resend = 0;
+ check_resend = false;
goto again;
}
} else {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-25 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-07 6:26 [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable xiakaixu1987
2020-11-07 7:36 ` Greg Kurz
2020-12-15 2:14 ` Paul Mackerras
2020-12-21 11:03 ` Michael Ellerman
2021-01-25 7:59 Jiapeng Zhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).