* [PATCH] IB/hfi1: remove h from printk format specifier
@ 2020-12-15 18:35 trix
2020-12-15 21:25 ` Mike Marciniszyn
2021-01-07 18:01 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-12-15 18:35 UTC (permalink / raw)
To: mike.marciniszyn, dennis.dalessandro, dledford, jgg
Cc: linux-rdma, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/infiniband/hw/hfi1/sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/sdma.c b/drivers/infiniband/hw/hfi1/sdma.c
index a307d4c8b15a..27ec2851160a 100644
--- a/drivers/infiniband/hw/hfi1/sdma.c
+++ b/drivers/infiniband/hw/hfi1/sdma.c
@@ -1740,7 +1740,7 @@ static inline u16 sdma_gethead(struct sdma_engine *sde)
sane = (hwhead == swhead);
if (unlikely(!sane)) {
- dd_dev_err(dd, "SDMA(%u) bad head (%s) hwhd=%hu swhd=%hu swtl=%hu cnt=%hu\n",
+ dd_dev_err(dd, "SDMA(%u) bad head (%s) hwhd=%u swhd=%u swtl=%u cnt=%u\n",
sde->this_idx,
use_dmahead ? "dma" : "kreg",
hwhead, swhead, swtail, cnt);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] IB/hfi1: remove h from printk format specifier
2020-12-15 18:35 [PATCH] IB/hfi1: remove h from printk format specifier trix
@ 2020-12-15 21:25 ` Mike Marciniszyn
2021-01-07 18:01 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Mike Marciniszyn @ 2020-12-15 21:25 UTC (permalink / raw)
To: trix, dennis.dalessandro, dledford, jgg; +Cc: linux-rdma, linux-kernel
On 12/15/2020 1:35 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/infiniband/hw/hfi1/sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Looks ok!
Mike
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/hfi1: remove h from printk format specifier
2020-12-15 18:35 [PATCH] IB/hfi1: remove h from printk format specifier trix
2020-12-15 21:25 ` Mike Marciniszyn
@ 2021-01-07 18:01 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-01-07 18:01 UTC (permalink / raw)
To: trix
Cc: mike.marciniszyn, dennis.dalessandro, dledford, linux-rdma, linux-kernel
On Tue, Dec 15, 2020 at 10:35:09AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/hfi1/sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-07 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 18:35 [PATCH] IB/hfi1: remove h from printk format specifier trix
2020-12-15 21:25 ` Mike Marciniszyn
2021-01-07 18:01 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).