linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.
@ 2020-12-17  8:14 Pi-Hsun Shih
  2020-12-17  8:14 ` [PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot Pi-Hsun Shih
  0 siblings, 1 reply; 3+ messages in thread
From: Pi-Hsun Shih @ 2020-12-17  8:14 UTC (permalink / raw)
  Cc: Pi-Hsun Shih, Nicolas Boichat, Benson Leung,
	Enric Balletbo i Serra, Guenter Roeck, Mark Brown,
	Prashant Malani, Gustavo A. R. Silva, open list

Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP.

Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>

---

The corresponding changes in ChromeOS EC firmware is at crrev.com/c/2428361

---
 include/linux/platform_data/cros_ec_commands.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index a3a9a878415f..b80a4a7038e4 100644
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -4729,6 +4729,7 @@ enum ec_reboot_cmd {
 	EC_REBOOT_DISABLE_JUMP = 5,  /* Disable jump until next reboot */
 	EC_REBOOT_HIBERNATE = 6,     /* Hibernate EC */
 	EC_REBOOT_HIBERNATE_CLEAR_AP_OFF = 7, /* and clears AP_OFF flag */
+	EC_REBOOT_COLD_AP_OFF = 8,   /* Cold-reboot and don't boot AP */
 };
 
 /* Flags for ec_params_reboot_ec.reboot_flags */

base-commit: accefff5b547a9a1d959c7e76ad539bf2480e78b
-- 
2.29.2.684.gfbc64c5ab5-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.
  2020-12-17  8:14 [PATCH 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset Pi-Hsun Shih
@ 2020-12-17  8:14 ` Pi-Hsun Shih
  2020-12-18 10:44   ` Enric Balletbo i Serra
  0 siblings, 1 reply; 3+ messages in thread
From: Pi-Hsun Shih @ 2020-12-17  8:14 UTC (permalink / raw)
  Cc: Pi-Hsun Shih, Nicolas Boichat, Benson Leung,
	Enric Balletbo i Serra, Guenter Roeck, open list

Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
---
 drivers/platform/chrome/cros_ec_sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
index f521a5c65091..8210fb10e839 100644
--- a/drivers/platform/chrome/cros_ec_sysfs.c
+++ b/drivers/platform/chrome/cros_ec_sysfs.c
@@ -28,7 +28,7 @@ static ssize_t reboot_show(struct device *dev,
 	int count = 0;
 
 	count += scnprintf(buf + count, PAGE_SIZE - count,
-			   "ro|rw|cancel|cold|disable-jump|hibernate");
+			   "ro|rw|cancel|cold|disable-jump|hibernate|cold-ap-off");
 	count += scnprintf(buf + count, PAGE_SIZE - count,
 			   " [at-shutdown]\n");
 	return count;
@@ -46,6 +46,7 @@ static ssize_t reboot_store(struct device *dev,
 		{"cancel",       EC_REBOOT_CANCEL, 0},
 		{"ro",           EC_REBOOT_JUMP_RO, 0},
 		{"rw",           EC_REBOOT_JUMP_RW, 0},
+		{"cold-ap-off",  EC_REBOOT_COLD_AP_OFF, 0},
 		{"cold",         EC_REBOOT_COLD, 0},
 		{"disable-jump", EC_REBOOT_DISABLE_JUMP, 0},
 		{"hibernate",    EC_REBOOT_HIBERNATE, 0},
-- 
2.29.2.684.gfbc64c5ab5-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.
  2020-12-17  8:14 ` [PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot Pi-Hsun Shih
@ 2020-12-18 10:44   ` Enric Balletbo i Serra
  0 siblings, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-12-18 10:44 UTC (permalink / raw)
  To: Pi-Hsun Shih; +Cc: Nicolas Boichat, Benson Leung, Guenter Roeck, open list

Hi Pi-Hsun,

Thank you for your patch. I don't accept patches with an empty commit
description. Can you add it? (maybe you could just explain more what cold-ap-off
means here. Apart from this, the patch LGTM.

Thanks,
  Enric


On 17/12/20 9:14, Pi-Hsun Shih wrote:
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
>  drivers/platform/chrome/cros_ec_sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
> index f521a5c65091..8210fb10e839 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -28,7 +28,7 @@ static ssize_t reboot_show(struct device *dev,
>  	int count = 0;
>  
>  	count += scnprintf(buf + count, PAGE_SIZE - count,
> -			   "ro|rw|cancel|cold|disable-jump|hibernate");
> +			   "ro|rw|cancel|cold|disable-jump|hibernate|cold-ap-off");
>  	count += scnprintf(buf + count, PAGE_SIZE - count,
>  			   " [at-shutdown]\n");
>  	return count;
> @@ -46,6 +46,7 @@ static ssize_t reboot_store(struct device *dev,
>  		{"cancel",       EC_REBOOT_CANCEL, 0},
>  		{"ro",           EC_REBOOT_JUMP_RO, 0},
>  		{"rw",           EC_REBOOT_JUMP_RW, 0},
> +		{"cold-ap-off",  EC_REBOOT_COLD_AP_OFF, 0},
>  		{"cold",         EC_REBOOT_COLD, 0},
>  		{"disable-jump", EC_REBOOT_DISABLE_JUMP, 0},
>  		{"hibernate",    EC_REBOOT_HIBERNATE, 0},
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-18 10:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17  8:14 [PATCH 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset Pi-Hsun Shih
2020-12-17  8:14 ` [PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot Pi-Hsun Shih
2020-12-18 10:44   ` Enric Balletbo i Serra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).