* [PATCH] staging: qlge: Removed duplicate word in comment.
@ 2020-12-19 1:48 Daniel West
2020-12-20 15:17 ` Kari Argillander
2020-12-28 14:07 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Daniel West @ 2020-12-19 1:48 UTC (permalink / raw)
To: manishc, GR-Linux-NIC-Dev
Cc: gregkh, netdev, devel, linux-kernel, Daniel West, Daniel West
This patch fixes the checkpatch warning:
WARNING: Possible repeated word: 'and'
Signed-off-by: Daniel West <daniel.s.west.dev@gmail.com>
---
drivers/staging/qlge/qlge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index e6b7baa12cd6..22167eca7c50 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3186,7 +3186,7 @@ static void ql_enable_msix(struct ql_adapter *qdev)
"Running with legacy interrupts.\n");
}
-/* Each vector services 1 RSS ring and and 1 or more
+/* Each vector services 1 RSS ring and 1 or more
* TX completion rings. This function loops through
* the TX completion rings and assigns the vector that
* will service it. An example would be if there are
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: qlge: Removed duplicate word in comment.
2020-12-19 1:48 [PATCH] staging: qlge: Removed duplicate word in comment Daniel West
@ 2020-12-20 15:17 ` Kari Argillander
2020-12-28 14:07 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Kari Argillander @ 2020-12-20 15:17 UTC (permalink / raw)
To: Daniel West
Cc: manishc, GR-Linux-NIC-Dev, gregkh, netdev, devel, linux-kernel,
Daniel West
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote:
> This patch fixes the checkpatch warning:
>
> WARNING: Possible repeated word: 'and'
>
> Signed-off-by: Daniel West <daniel.s.west.dev@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index e6b7baa12cd6..22167eca7c50 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3186,7 +3186,7 @@ static void ql_enable_msix(struct ql_adapter *qdev)
> "Running with legacy interrupts.\n");
> }
>
> -/* Each vector services 1 RSS ring and and 1 or more
> +/* Each vector services 1 RSS ring and 1 or more
> * TX completion rings. This function loops through
> * the TX completion rings and assigns the vector that
> * will service it. An example would be if there are
Patch it self looks good. I nit pick a little bit because this is
staging and were here to learn mostly. You should use imperative mood
in subject line. So Removed -> Remove. Also no period in subject line.
I'm also confused by your email. Other patch which you send has sign of
is with daniel.s.west.dev and another is daniel.west.dev. So do you use
both? I also think that you made this email becouse you want to get all
lkml mails. That is perfectly fine and many does this. But many does it
just for reading. That way if someone needs to send you email it wont be
lost because you do not read that email anymore. Many does that they
still send messages from they real email so that email do get so many
emails. This is ofcourse your decission I'm just telling you options.
--
Kari Argillander
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: qlge: Removed duplicate word in comment.
2020-12-19 1:48 [PATCH] staging: qlge: Removed duplicate word in comment Daniel West
2020-12-20 15:17 ` Kari Argillander
@ 2020-12-28 14:07 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-12-28 14:07 UTC (permalink / raw)
To: Daniel West
Cc: manishc, GR-Linux-NIC-Dev, devel, linux-kernel, Daniel West, netdev
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote:
> This patch fixes the checkpatch warning:
>
> WARNING: Possible repeated word: 'and'
>
> Signed-off-by: Daniel West <daniel.s.west.dev@gmail.com>
signed-off-by does not match From: line, so I can't take this :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-28 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-19 1:48 [PATCH] staging: qlge: Removed duplicate word in comment Daniel West
2020-12-20 15:17 ` Kari Argillander
2020-12-28 14:07 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).