From: Kari Argillander <kari.argillander@gmail.com>
To: Daniel West <daniel.west.dev@gmail.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
insafonov@gmail.com, gustavoars@kernel.org,
andrealmeidap1996@gmail.com, yepeilin.cs@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
Date: Sun, 20 Dec 2020 17:29:21 +0200 [thread overview]
Message-ID: <20201220152921.dqlsmqfvygtpzj5b@kari-VirtualBox> (raw)
In-Reply-To: <20201219224312.380126-1-daniel.west.dev@gmail.com>
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> Fixed a checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
> #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> +/****************************************************************************
> +
>
> The code is full of comments like this. Should the coding style
> be inforced here, even when there is a logic to the way the code
> was broken up?
You should make one patch which atleast fix one file at ones. It would
be even better if it fixes whole stuff (example one driver) right a way.
Also note that you should not but this kind messages to your patch
message. If you want to note this kind of thing you can use --- and
after that it will not included in patch itself. You can read it online
more.
Also where does this [PATCH 8455/8455] even come from? Good thing is
that you really didn't send so many patches or atleast I won't see them.
And it seems that you are new so welcome a board :)
--
Kari Argillander
next prev parent reply other threads:[~2020-12-20 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 22:43 [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue Daniel West
2020-12-20 15:29 ` Kari Argillander [this message]
2020-12-28 14:09 ` Greg KH
2020-12-28 19:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201220152921.dqlsmqfvygtpzj5b@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrealmeidap1996@gmail.com \
--cc=daniel.west.dev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).