From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Daniel West <daniel.west.dev@gmail.com>
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
insafonov@gmail.com, gustavoars@kernel.org,
andrealmeidap1996@gmail.com, linux-kernel@vger.kernel.org,
yepeilin.cs@gmail.com
Subject: Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
Date: Mon, 28 Dec 2020 11:47:27 -0800 [thread overview]
Message-ID: <4aeb47e4aa643181e462328104ef63c66eaf587b.camel@perches.com> (raw)
In-Reply-To: <X+nnAwy/a7mZlmeL@kroah.com>
On Mon, 2020-12-28 at 15:09 +0100, Greg KH wrote:
> On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> > Fixed a checkpatch warning:
> >
> > WARNING: Block comments use * on subsequent lines
> > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> > +/****************************************************************************
> > +
> >
> > The code is full of comments like this. Should the coding style
> > be inforced here, even when there is a logic to the way the code
> > was broken up?
[]
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
[]
> > @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
> > }
> > }
> >
> >
> > -/****************************************************************************
> > -
> > -Following are the functions for the timer handlers
> > -
> > -*****************************************************************************/
> > +/*
> > + *
> > + *Following are the functions for the timer handlers
> > + */
>
> Does that look correct? Make it all one line please.
Just:
/* timer handler functions */
would be simpler.
And the code is mostly a horror to read.
prev parent reply other threads:[~2020-12-28 23:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 22:43 [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue Daniel West
2020-12-20 15:29 ` Kari Argillander
2020-12-28 14:09 ` Greg KH
2020-12-28 19:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aeb47e4aa643181e462328104ef63c66eaf587b.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrealmeidap1996@gmail.com \
--cc=daniel.west.dev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).