* [PATCH -next] greybus/audio_helper: Add missing unlock to avoid mismatched lock
@ 2020-12-21 13:02 Zheng Yongjun
2020-12-21 14:49 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-21 13:02 UTC (permalink / raw)
To: johan, elder, gregkh, greybus-dev, devel, linux-kernel; +Cc: Zheng Yongjun
Fix a missing unlock in the error branch.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/staging/greybus/audio_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c
index 237531ba60f3..293675dbea10 100644
--- a/drivers/staging/greybus/audio_helper.c
+++ b/drivers/staging/greybus/audio_helper.c
@@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
if (!w) {
dev_err(dapm->dev, "%s: widget not found\n",
widget->name);
+ mutex_unlock(&dapm->card->dapm_mutex);
return -EINVAL;
}
widget++;
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] greybus/audio_helper: Add missing unlock to avoid mismatched lock
2020-12-21 13:02 [PATCH -next] greybus/audio_helper: Add missing unlock to avoid mismatched lock Zheng Yongjun
@ 2020-12-21 14:49 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-12-21 14:49 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: johan, elder, gregkh, greybus-dev, devel, linux-kernel
On Mon, Dec 21, 2020 at 09:02:46PM +0800, Zheng Yongjun wrote:
> Fix a missing unlock in the error branch.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/greybus/audio_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c
> index 237531ba60f3..293675dbea10 100644
> --- a/drivers/staging/greybus/audio_helper.c
> +++ b/drivers/staging/greybus/audio_helper.c
> @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
> if (!w) {
> dev_err(dapm->dev, "%s: widget not found\n",
> widget->name);
> + mutex_unlock(&dapm->card->dapm_mutex);
> return -EINVAL;
> }
> widget++;
This has already been fixed in mainline by your colleague:
e77b259f67ab ("staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls")
It seems you're all working on reports from your "Hulk Robot" so perhaps
you can try to coordinate that internally.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-21 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 13:02 [PATCH -next] greybus/audio_helper: Add missing unlock to avoid mismatched lock Zheng Yongjun
2020-12-21 14:49 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).