* [PATCH] Kernel: Fixed two bracket problems in fork.c
@ 2020-12-21 15:05 Alexander Guril
2020-12-21 18:42 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Guril @ 2020-12-21 15:05 UTC (permalink / raw)
To: christian.brauner, akpm; +Cc: linux-kernel, Alexander Guril
This fixes two bracket problems in kernel/fork.c
Signed-off-by: Alexander Guril <alexander.guril02@gmail.com>
---
kernel/fork.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 41906a52a764..3a5301867297 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -819,9 +819,8 @@ void __init fork_init(void)
init_task.signal->rlim[RLIMIT_SIGPENDING] =
init_task.signal->rlim[RLIMIT_NPROC];
- for (i = 0; i < UCOUNT_COUNTS; i++) {
+ for (i = 0; i < UCOUNT_COUNTS; i++)
init_user_ns.ucount_max[i] = max_threads/2;
- }
#ifdef CONFIG_VMAP_STACK
cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "fork:vm_stack_cache",
@@ -1654,9 +1653,8 @@ static inline void init_task_pid_links(struct task_struct *task)
{
enum pid_type type;
- for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type) {
+ for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type)
INIT_HLIST_NODE(&task->pid_links[type]);
- }
}
static inline void
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Kernel: Fixed two bracket problems in fork.c
2020-12-21 15:05 [PATCH] Kernel: Fixed two bracket problems in fork.c Alexander Guril
@ 2020-12-21 18:42 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2020-12-21 18:42 UTC (permalink / raw)
To: Alexander Guril; +Cc: akpm, linux-kernel
On Mon, Dec 21, 2020 at 04:05:02PM +0100, Alexander Guril wrote:
> This fixes two bracket problems in kernel/fork.c
>
> Signed-off-by: Alexander Guril <alexander.guril02@gmail.com>
> ---
Thanks for the patch.
Unfortunately, there's no real rationale for the change in the commit
message. You probably want to mention that our coding-style mandates
that we don't use {} around single-line statements.
Christian
> kernel/fork.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 41906a52a764..3a5301867297 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -819,9 +819,8 @@ void __init fork_init(void)
> init_task.signal->rlim[RLIMIT_SIGPENDING] =
> init_task.signal->rlim[RLIMIT_NPROC];
>
> - for (i = 0; i < UCOUNT_COUNTS; i++) {
> + for (i = 0; i < UCOUNT_COUNTS; i++)
> init_user_ns.ucount_max[i] = max_threads/2;
> - }
>
> #ifdef CONFIG_VMAP_STACK
> cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "fork:vm_stack_cache",
> @@ -1654,9 +1653,8 @@ static inline void init_task_pid_links(struct task_struct *task)
> {
> enum pid_type type;
>
> - for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type) {
> + for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type)
> INIT_HLIST_NODE(&task->pid_links[type]);
> - }
> }
>
> static inline void
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-21 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 15:05 [PATCH] Kernel: Fixed two bracket problems in fork.c Alexander Guril
2020-12-21 18:42 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).