linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arch/Kconfig: JUMP_LABEL should depend on !XIP
@ 2020-12-21 20:40 Vitaly Wool
  0 siblings, 0 replies; only message in thread
From: Vitaly Wool @ 2020-12-21 20:40 UTC (permalink / raw)
  To: linux-kernel, linux-mm; +Cc: Nicolas Pitre, Vitaly Wool

There's no point in trying to optimize the code when the code is
executed from a read-only medium (e. g. NOR flash) as in the XIP
case. Moreover, trying to do so in a XIP kernel may result in
faults and kernel crashes so let's explicitly disallow JUMP_LABEL
if XIP_KERNEL configuration option is set.

Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
---
 arch/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/Kconfig b/arch/Kconfig
index 56b6ccc0e32d..88632c9588ae 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -81,6 +81,7 @@ config JUMP_LABEL
 	bool "Optimize very unlikely/likely branches"
 	depends on HAVE_ARCH_JUMP_LABEL
 	depends on CC_HAS_ASM_GOTO
+	depends on !XIP_KERNEL
 	help
 	 This option enables a transparent branch optimization that
 	 makes certain almost-always-true or almost-always-false branch
-- 
2.29.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-21 20:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 20:40 [PATCH] arch/Kconfig: JUMP_LABEL should depend on !XIP Vitaly Wool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).