From: Mark Brown <broonie@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Laxminath Kasam <lkasam@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Robert Jones <rjones@gateworks.com>
Subject: Re: [PATCH] regmap: irq: do not allow setting irq bits during ack
Date: Tue, 29 Dec 2020 13:06:29 +0000 [thread overview]
Message-ID: <20201229130629.GD4786@sirena.org.uk> (raw)
In-Reply-To: <1609191951-15590-1-git-send-email-tharvey@gateworks.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Mon, Dec 28, 2020 at 01:45:51PM -0800, Tim Harvey wrote:
> Some interrupt controllers may not de-assert their interrupt if
> bits are set when acknowledging the bits that caused the interrupt.
> Take care to not apply the mask to the status until we are done
> acknowledging the interrupt and take care to mask the bits according
> for the ack_invert state.
I can't understand what this commit message is trying to say, sorry.
Which bits are you talking about when you say "if bits are set"? Isn't
acknowleding the interrupt clearing the bits asserting the interrupt? I
can't tell what the problem you're trying to fix is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-29 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 21:45 [PATCH] regmap: irq: do not allow setting irq bits during ack Tim Harvey
2020-12-29 13:06 ` Mark Brown [this message]
2020-12-29 16:23 ` Tim Harvey
2020-12-30 13:14 ` Mark Brown
2020-12-30 16:37 ` Tim Harvey
2020-12-31 13:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229130629.GD4786@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkasam@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjones@gateworks.com \
--cc=tharvey@gateworks.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).