From: Tim Harvey <tharvey@gateworks.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Laxminath Kasam <lkasam@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Robert Jones <rjones@gateworks.com>
Subject: Re: [PATCH] regmap: irq: do not allow setting irq bits during ack
Date: Wed, 30 Dec 2020 08:37:17 -0800 [thread overview]
Message-ID: <CAJ+vNU0rC65wCpt3m+_pp6Qufw8Ni97Z4o5j3n3LTqBYzCvyxg@mail.gmail.com> (raw)
In-Reply-To: <20201230131402.GA4428@sirena.org.uk>
On Wed, Dec 30, 2020 at 5:14 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Dec 29, 2020 at 08:23:00AM -0800, Tim Harvey wrote:
> > On Tue, Dec 29, 2020 at 5:06 AM Mark Brown <broonie@kernel.org> wrote:
>
> > > I can't understand what this commit message is trying to say, sorry.
> > > Which bits are you talking about when you say "if bits are set"? Isn't
> > > acknowleding the interrupt clearing the bits asserting the interrupt? I
> > > can't tell what the problem you're trying to fix is.
>
> > If for example status=0x01 the current code for ack_invert will write
> > a 0xfe to clear that bit which ends up setting all other interrupt
> > bits keeping the interrupt from ever being de-asserted. With the patch
> > applied a status=0x01 will result in a 0x00 written to clear that bit
> > and keep other's from being set.
>
> But that's not an inverted ack as far as I can see? That's writing back
> the bit you're trying to clear which is the default ack. Why do you
> believe this is an inverted ack? In any case the changelog for the
> patch needs to be clear.
Mark,
It 'is' inverted ack because the device I have requires a '0' to be
written to clear the interrupt instead of a '1'.
The chip I'm using has a status register where bit values of 1
indicate an interrupt assertion and to clear it you write a 0 (where
as the typical non-ack-invert case you write a 1 to clear). The chip
I'm using also allows you to 'set' (by writing a 1) to bits that were
not already set which would keep it from de-asserting it's interrupt.
Honestly I thought the commit message was very clear. What exactly is
your suggestion? It is of course confusing when talking about code
that handles both ack invert and the normal case (let alone the new
case of 'clear_ack').
Best regards,
Tim
next prev parent reply other threads:[~2020-12-30 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 21:45 [PATCH] regmap: irq: do not allow setting irq bits during ack Tim Harvey
2020-12-29 13:06 ` Mark Brown
2020-12-29 16:23 ` Tim Harvey
2020-12-30 13:14 ` Mark Brown
2020-12-30 16:37 ` Tim Harvey [this message]
2020-12-31 13:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+vNU0rC65wCpt3m+_pp6Qufw8Ni97Z4o5j3n3LTqBYzCvyxg@mail.gmail.com \
--to=tharvey@gateworks.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkasam@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjones@gateworks.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).