[PATCH] genirq: Export irq_check_status_bit

[PATCH] genirq: Export irq_check_status_bit

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Changing some inline functions to use the new irq_check_status_bit
function out of line breaks calling them from loadable modules:

ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!

Export the function to make it work again. One can debate over
whether this should be EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL(),
as it could be called from any module before and making it GPL-only
changes behavior. However all other symbols in this file are
EXPORT_SYMBOL_GPL(), so I went with that for consistency.

Fixes: fdd029630434 ("genirq: Move status flag checks to core")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/irq/manage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index ab8567f32501..dec3f73e8db9 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2859,3 +2859,4 @@ bool irq_check_status_bit(unsigned int irq, unsigned int bitmask)
 	rcu_read_unlock();
 	return res;
 }
+EXPORT_SYMBOL_GPL(irq_check_status_bit);
-- 
2.29.2

Re: [PATCH] genirq: Export irq_check_status_bit

[Thorsten Leemhuis]

Am 30.12.20 um 16:45 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Changing some inline functions to use the new irq_check_status_bit
> function out of line breaks calling them from loadable modules:
> 
> ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!

Just FYI: Levi Yun sent a similar patch a on Dec, 26 already:
https://lore.kernel.org/lkml/20201226123818.GA693525@ubuntu/

But nothing happened afaics, the festival season is taking its toll. ;-)

I'd like to see this fixed, too, as it broke my
Kernel Vanilla builds for Fedora
(https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories) just a day
after I finally started building packages for aarch64, too. Bad timing. :-D

Ciao, Thorsten