* [PATCH] pinctrl: nomadik: remove an unused variable
@ 2020-12-30 15:46 Arnd Bergmann
2020-12-31 2:07 ` Andrew Halaney
2021-01-05 22:25 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-30 15:46 UTC (permalink / raw)
To: Linus Walleij, Thomas Gleixner
Cc: Arnd Bergmann, Geert Uytterhoeven, Andrew Halaney, Jacopo Mondi,
Ding Xiang, Matti Vaittinen, linux-arm-kernel, linux-gpio,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent patch added a local variable twice:
drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]
Remove the unused outer declaration
Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index d4ea10803fd9..abfe11c7b49f 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
} else {
int irq = chip->to_irq(chip, offset);
const int pullidx = pull ? 1 : 0;
- bool wake;
int val;
static const char * const pulls[] = {
"none ",
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nomadik: remove an unused variable
2020-12-30 15:46 [PATCH] pinctrl: nomadik: remove an unused variable Arnd Bergmann
@ 2020-12-31 2:07 ` Andrew Halaney
2021-01-05 22:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Halaney @ 2020-12-31 2:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Thomas Gleixner, Arnd Bergmann,
Geert Uytterhoeven, Jacopo Mondi, Ding Xiang, Matti Vaittinen,
linux-arm-kernel, linux-gpio, linux-kernel
On Wed, Dec 30, 2020 at 04:46:17PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch added a local variable twice:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]
>
> Remove the unused outer declaration
>
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index d4ea10803fd9..abfe11c7b49f 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
> } else {
> int irq = chip->to_irq(chip, offset);
> const int pullidx = pull ? 1 : 0;
> - bool wake;
> int val;
> static const char * const pulls[] = {
> "none ",
> --
> 2.29.2
>
Got rid of the warning for me, I don't have hardware to test on but I
don't think that's necessary for this.
Tested-by: Andrew Halaney <ajhalaney@gmail.com>
Reviewed-by: Andrew Halaney <ajhalaney@gmail.com>
Thanks,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nomadik: remove an unused variable
2020-12-30 15:46 [PATCH] pinctrl: nomadik: remove an unused variable Arnd Bergmann
2020-12-31 2:07 ` Andrew Halaney
@ 2021-01-05 22:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-01-05 22:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thomas Gleixner, Arnd Bergmann, Geert Uytterhoeven,
Andrew Halaney, Jacopo Mondi, Ding Xiang, Matti Vaittinen,
Linux ARM, open list:GPIO SUBSYSTEM, linux-kernel
On Wed, Dec 30, 2020 at 4:46 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch added a local variable twice:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]
>
> Remove the unused outer declaration
>
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I got an identical patch from Nathan Chancellor on dec 29 :D
I'll add your reported-by and Andrews tags.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-05 22:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 15:46 [PATCH] pinctrl: nomadik: remove an unused variable Arnd Bergmann
2020-12-31 2:07 ` Andrew Halaney
2021-01-05 22:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).