* [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning
@ 2020-12-30 15:44 Arnd Bergmann
2020-12-31 8:12 ` Nathan Chancellor
2020-12-31 20:07 ` Nicolin Chen
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-30 15:44 UTC (permalink / raw)
To: Timur Tabi, Nicolin Chen, Mark Brown
Cc: Arnd Bergmann, Xiubo Li, Fabio Estevam, Shengjiu Wang,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Nathan Chancellor, Nick Desaulniers, alsa-devel, linuxppc-dev,
linux-arm-kernel, linux-kernel, clang-built-linux
From: Arnd Bergmann <arnd@arndb.de>
Clang points out a code path that returns an undefined value
in an error case:
sound/soc/fsl/imx-hdmi.c:165:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsom
etimes-uninitialized]
if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/fsl/imx-hdmi.c:212:9: note: uninitialized use occurs here
return ret;
The driver returns -EINVAL for other broken DT properties, so do
it the same way here.
Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/fsl/imx-hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
index 2c2a76a71940..ede4a9ad1054 100644
--- a/sound/soc/fsl/imx-hdmi.c
+++ b/sound/soc/fsl/imx-hdmi.c
@@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
+ ret = -EINVAL;
goto fail;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning
2020-12-30 15:44 [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning Arnd Bergmann
@ 2020-12-31 8:12 ` Nathan Chancellor
2020-12-31 20:07 ` Nicolin Chen
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2020-12-31 8:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Timur Tabi, Nicolin Chen, Mark Brown, Arnd Bergmann, Xiubo Li,
Fabio Estevam, Shengjiu Wang, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team, Nick Desaulniers, alsa-devel, linuxppc-dev,
linux-arm-kernel, linux-kernel, clang-built-linux
On Wed, Dec 30, 2020 at 04:44:15PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Clang points out a code path that returns an undefined value
> in an error case:
>
> sound/soc/fsl/imx-hdmi.c:165:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsom
> etimes-uninitialized]
> if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/fsl/imx-hdmi.c:212:9: note: uninitialized use occurs here
> return ret;
>
> The driver returns -EINVAL for other broken DT properties, so do
> it the same way here.
>
> Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> sound/soc/fsl/imx-hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
> index 2c2a76a71940..ede4a9ad1054 100644
> --- a/sound/soc/fsl/imx-hdmi.c
> +++ b/sound/soc/fsl/imx-hdmi.c
> @@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
>
> if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
> dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
> + ret = -EINVAL;
> goto fail;
> }
>
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning
2020-12-30 15:44 [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning Arnd Bergmann
2020-12-31 8:12 ` Nathan Chancellor
@ 2020-12-31 20:07 ` Nicolin Chen
1 sibling, 0 replies; 3+ messages in thread
From: Nicolin Chen @ 2020-12-31 20:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Timur Tabi, Mark Brown, Arnd Bergmann, Xiubo Li, Fabio Estevam,
Shengjiu Wang, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Nathan Chancellor, Nick Desaulniers, alsa-devel, linuxppc-dev,
linux-arm-kernel, linux-kernel, clang-built-linux
On Wed, Dec 30, 2020 at 04:44:15PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Clang points out a code path that returns an undefined value
> in an error case:
>
> sound/soc/fsl/imx-hdmi.c:165:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsom
> etimes-uninitialized]
> if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/fsl/imx-hdmi.c:212:9: note: uninitialized use occurs here
> return ret;
>
> The driver returns -EINVAL for other broken DT properties, so do
> it the same way here.
>
> Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/fsl/imx-hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
> index 2c2a76a71940..ede4a9ad1054 100644
> --- a/sound/soc/fsl/imx-hdmi.c
> +++ b/sound/soc/fsl/imx-hdmi.c
> @@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
>
> if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
> dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
> + ret = -EINVAL;
> goto fail;
I think Mark has already applied a fix :)
https://lkml.org/lkml/2020/12/16/275
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-31 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 15:44 [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning Arnd Bergmann
2020-12-31 8:12 ` Nathan Chancellor
2020-12-31 20:07 ` Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).