linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block: rsxx: select CONFIG_CRC32
@ 2021-01-03 21:42 Arnd Bergmann
  2021-01-03 21:54 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-01-03 21:42 UTC (permalink / raw)
  To: Jens Axboe, Philip J Kelleher
  Cc: Arnd Bergmann, Hannes Reinecke, Damien Le Moal, linux-block,
	linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without crc32, the driver fails to link:

arm-linux-gnueabi-ld: drivers/block/rsxx/config.o: in function `rsxx_load_config':
config.c:(.text+0x124): undefined reference to `crc32_le'

Fixes: 8722ff8cdbfa ("block: IBM RamSan 70/80 device driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/block/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 262326973ee0..583b671b1d2d 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -445,6 +445,7 @@ config BLK_DEV_RBD
 config BLK_DEV_RSXX
 	tristate "IBM Flash Adapter 900GB Full Height PCIe Device Driver"
 	depends on PCI
+	select CRC32
 	help
 	  Device driver for IBM's high speed PCIe SSD
 	  storage device: Flash Adapter 900GB Full Height.
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: rsxx: select CONFIG_CRC32
  2021-01-03 21:42 [PATCH] block: rsxx: select CONFIG_CRC32 Arnd Bergmann
@ 2021-01-03 21:54 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-01-03 21:54 UTC (permalink / raw)
  To: Arnd Bergmann, Philip J Kelleher
  Cc: Arnd Bergmann, Hannes Reinecke, Damien Le Moal, linux-block,
	linux-kernel

On 1/3/21 2:42 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Without crc32, the driver fails to link:
> 
> arm-linux-gnueabi-ld: drivers/block/rsxx/config.o: in function `rsxx_load_config':
> config.c:(.text+0x124): undefined reference to `crc32_le'

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-03 21:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03 21:42 [PATCH] block: rsxx: select CONFIG_CRC32 Arnd Bergmann
2021-01-03 21:54 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).