* [PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes
@ 2021-01-05 9:38 Paul Kocialkowski
2021-01-05 12:58 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Paul Kocialkowski @ 2021-01-05 9:38 UTC (permalink / raw)
To: linux-media, linux-kernel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Paul Kocialkowski
This solves a few minor cosmetic issues picked up by checkpatch for
the OV5648 and OV8865 drivers.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/i2c/ov5648.c | 2 +-
drivers/media/i2c/ov8865.c | 7 +++----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
index 609aa67b54ce..752a2e035c49 100644
--- a/drivers/media/i2c/ov5648.c
+++ b/drivers/media/i2c/ov5648.c
@@ -496,7 +496,7 @@
container_of(s, struct ov5648_sensor, subdev)
#define ov5648_ctrl_subdev(c) \
- (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev)
+ (&container_of((c)->handler, struct ov5648_sensor, ctrls.handler)->subdev)
/* Data structures */
diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index fda5a55979aa..704d75b601e3 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -223,7 +223,6 @@
#define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)
#define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0)
-
#define OV8865_INC_Y_ODD_REG 0x382a
#define OV8865_INC_Y_ODD(v) ((v) & GENMASK(4, 0))
#define OV8865_INC_Y_EVEN_REG 0x382b
@@ -460,7 +459,7 @@
container_of(s, struct ov8865_sensor, subdev)
#define ov8865_ctrl_subdev(c) \
- (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev)
+ (&container_of((c)->handler, struct ov8865_sensor, ctrls.handler)->subdev)
/* Data structures */
@@ -1598,8 +1597,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor,
return ret;
ret = ov8865_update_bits(sensor, OV8865_PCLK_SEL_REG,
- OV8865_PCLK_SEL_PCLK_DIV_MASK,
- OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
+ OV8865_PCLK_SEL_PCLK_DIV_MASK,
+ OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
if (ret)
return ret;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes
2021-01-05 9:38 [PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes Paul Kocialkowski
@ 2021-01-05 12:58 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2021-01-05 12:58 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
Hi Paul,
Thanks for the patch.
On Tue, Jan 05, 2021 at 10:38:03AM +0100, Paul Kocialkowski wrote:
> This solves a few minor cosmetic issues picked up by checkpatch for
> the OV5648 and OV8865 drivers.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> drivers/media/i2c/ov5648.c | 2 +-
> drivers/media/i2c/ov8865.c | 7 +++----
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> index 609aa67b54ce..752a2e035c49 100644
> --- a/drivers/media/i2c/ov5648.c
> +++ b/drivers/media/i2c/ov5648.c
> @@ -496,7 +496,7 @@
> container_of(s, struct ov5648_sensor, subdev)
>
> #define ov5648_ctrl_subdev(c) \
> - (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev)
> + (&container_of((c)->handler, struct ov5648_sensor, ctrls.handler)->subdev)
Over 80; please wrap.
>
> /* Data structures */
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index fda5a55979aa..704d75b601e3 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -223,7 +223,6 @@
> #define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)
> #define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0)
>
> -
> #define OV8865_INC_Y_ODD_REG 0x382a
> #define OV8865_INC_Y_ODD(v) ((v) & GENMASK(4, 0))
> #define OV8865_INC_Y_EVEN_REG 0x382b
> @@ -460,7 +459,7 @@
> container_of(s, struct ov8865_sensor, subdev)
>
> #define ov8865_ctrl_subdev(c) \
> - (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev)
> + (&container_of((c)->handler, struct ov8865_sensor, ctrls.handler)->subdev)
Ditto.
>
> /* Data structures */
>
> @@ -1598,8 +1597,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor,
> return ret;
>
> ret = ov8865_update_bits(sensor, OV8865_PCLK_SEL_REG,
> - OV8865_PCLK_SEL_PCLK_DIV_MASK,
> - OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
> + OV8865_PCLK_SEL_PCLK_DIV_MASK,
> + OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
> if (ret)
> return ret;
>
> --
> 2.29.2
>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-05 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 9:38 [PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes Paul Kocialkowski
2021-01-05 12:58 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).