* [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines
@ 2021-01-06 13:05 Jeremy Szu
2021-01-07 10:40 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Szu @ 2021-01-06 13:05 UTC (permalink / raw)
To: tiwai
Cc: Jeremy Szu, Jaroslav Kysela, Kailang Yang, Jian-Hong Pan,
Kai-Heng Feng, Hui Wang, Huacai Chen, Thomas Hebb,
moderated list:SOUND, open list
* The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
which is using 0x04 to control mute LED and 0x01 to control micmute LED.
* The right channel speaker is no sound and it needs to expose GPIO1 for
initialing AMP.
Add quirks to support them.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3c1d2a3fb1a4..dd82ff2bd5d6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7970,6 +7970,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
+ ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
+ ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines
2021-01-06 13:05 [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines Jeremy Szu
@ 2021-01-07 10:40 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-07 10:40 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Kailang Yang, Jian-Hong Pan,
Kai-Heng Feng, Hui Wang, Huacai Chen, Thomas Hebb,
moderated list:SOUND, open list
On Wed, 06 Jan 2021 14:05:46 +0100,
Jeremy Szu wrote:
>
> * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
> which is using 0x04 to control mute LED and 0x01 to control micmute LED.
>
> * The right channel speaker is no sound and it needs to expose GPIO1 for
> initialing AMP.
>
> Add quirks to support them.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines
2022-03-14 14:21 Andy Chi
@ 2022-03-14 17:00 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-03-14 17:00 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Jeremy Szu, Hui Wang,
Werner Sembach, Lucas Tanure, Cameron Berkenpas, Kailang Yang,
Sami Loone, alsa-devel, linux-kernel
On Mon, 14 Mar 2022 15:21:19 +0100,
Andy Chi wrote:
>
> * The HP ProBook 440/450 and EliteBook 640/650 are
> using ALC236 codec which used 0x02 to control mute LED
> and 0x01 to control micmute LED. Therefore, add a quirk to make it works.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines
@ 2022-03-14 14:21 Andy Chi
2022-03-14 17:00 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Andy Chi @ 2022-03-14 14:21 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Jeremy Szu, Hui Wang,
Werner Sembach, Lucas Tanure, Cameron Berkenpas, Kailang Yang,
Sami Loone, alsa-devel, linux-kernel
Cc: andy.chi
* The HP ProBook 440/450 and EliteBook 640/650 are
using ALC236 codec which used 0x02 to control mute LED
and 0x01 to control micmute LED. Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c34b4888978b..4650ef9110d6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9017,6 +9017,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8992, "HP EliteBook 845 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8994, "HP EliteBook 855 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8995, "HP EliteBook 855 G9", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x103c, 0x89a4, "HP ProBook 440 G9", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x89a6, "HP ProBook 450 G9", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x89ac, "HP EliteBook 640 G9", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x89ae, "HP EliteBook 650 G9", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-14 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 13:05 [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines Jeremy Szu
2021-01-07 10:40 ` Takashi Iwai
2022-03-14 14:21 Andy Chi
2022-03-14 17:00 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).