* [PATCH -next] media: atomisp: use resource_size
@ 2021-01-06 13:17 Zheng Yongjun
2021-01-06 13:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-01-06 13:17 UTC (permalink / raw)
To: mchehab, linux-media, devel, linux-kernel
Cc: sakari.ailus, gregkh, Zheng Yongjun
Use resource_size rather than a verbose computation on
the end and start fields.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/staging/media/atomisp/pci/sh_css_params.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
index 24fc497bd491..4a02948e5612 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_params.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
@@ -949,7 +949,7 @@ sh_css_set_black_frame(struct ia_css_stream *stream,
params = stream->isp_params_configs;
height = raw_black_frame->info.res.height;
- width = raw_black_frame->info.padded_width,
+ width = raw_black_frame->info.padded_width;
ptr = raw_black_frame->data
+ raw_black_frame->planes.raw.offset;
@@ -1443,7 +1443,7 @@ static int sh_css_params_default_morph_table(
IA_CSS_ENTER_PRIVATE("");
step = (ISP_VEC_NELEMS / 16) * 128,
- width = binary->morph_tbl_width,
+ width = binary->morph_tbl_width;
height = binary->morph_tbl_height;
tab = ia_css_morph_table_allocate(width, height);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: atomisp: use resource_size
2021-01-06 13:17 [PATCH -next] media: atomisp: use resource_size Zheng Yongjun
@ 2021-01-06 13:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-01-06 13:47 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: mchehab, linux-media, devel, linux-kernel, sakari.ailus
On Wed, Jan 06, 2021 at 09:17:37PM +0800, Zheng Yongjun wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/media/atomisp/pci/sh_css_params.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
> index 24fc497bd491..4a02948e5612 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_params.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
> @@ -949,7 +949,7 @@ sh_css_set_black_frame(struct ia_css_stream *stream,
>
> params = stream->isp_params_configs;
> height = raw_black_frame->info.res.height;
> - width = raw_black_frame->info.padded_width,
> + width = raw_black_frame->info.padded_width;
d>
> ptr = raw_black_frame->data
> + raw_black_frame->planes.raw.offset;
> @@ -1443,7 +1443,7 @@ static int sh_css_params_default_morph_table(
> IA_CSS_ENTER_PRIVATE("");
>
> step = (ISP_VEC_NELEMS / 16) * 128,
> - width = binary->morph_tbl_width,
> + width = binary->morph_tbl_width;
> height = binary->morph_tbl_height;
>
> tab = ia_css_morph_table_allocate(width, height);
> --
> 2.22.0
>
Your description does not match what the patch does at all :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-06 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 13:17 [PATCH -next] media: atomisp: use resource_size Zheng Yongjun
2021-01-06 13:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).