linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Lobakin <alobakin@pm.me>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	Pei Huang <huangpei@loongson.cn>,
	Kees Cook <keescook@chromium.org>,
	Alexander Lobakin <alobakin@pm.me>,
	Fangrui Song <maskray@google.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Corey Minyard <cminyard@mvista.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, stable@vger.kernel.org,
	clang-built-linux@googlegroups.com
Subject: [PATCH v5 mips-next 5/9] MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols
Date: Sun, 10 Jan 2021 11:56:34 +0000	[thread overview]
Message-ID: <20210110115546.30970-5-alobakin@pm.me> (raw)
In-Reply-To: <20210110115546.30970-1-alobakin@pm.me>

According to linker warnings, both GCC and LLVM generate '.rel.dyn'
symbols:

mips-alpine-linux-musl-ld: warning: orphan section `.rel.dyn'
from `init/main.o' being placed in section `.rel.dyn'

Link-time assertion shows that this section is sometimes empty,
sometimes not, depending on machine bitness and the compiler [0]:

  LD      .tmp_vmlinux.kallsyms1
mips64-linux-gnu-ld: Unexpected run-time relocations (.rel) detected!

Just use the ARM64 approach and declare it in vmlinux.lds.S closer
to __init_end.

[0] https://lore.kernel.org/linux-mips/20210109111259.GA4213@alpha.franken.de

Reported-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 arch/mips/kernel/vmlinux.lds.S | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
index 10d8f0dcb76b..70bba1ff08da 100644
--- a/arch/mips/kernel/vmlinux.lds.S
+++ b/arch/mips/kernel/vmlinux.lds.S
@@ -137,6 +137,11 @@ SECTIONS
 	PERCPU_SECTION(1 << CONFIG_MIPS_L1_CACHE_SHIFT)
 #endif
 
+	.rel.dyn : ALIGN(8) {
+		*(.rel)
+		*(.rel*)
+	}
+
 #ifdef CONFIG_MIPS_ELF_APPENDED_DTB
 	.appended_dtb : AT(ADDR(.appended_dtb) - LOAD_OFFSET) {
 		*(.appended_dtb)
-- 
2.30.0



  parent reply	other threads:[~2021-01-10 11:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 11:53 [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 1/9] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section Alexander Lobakin
2021-01-10 11:56   ` [PATCH v5 mips-next 2/9] MIPS: CPS: don't create redundant .text.cps-vec section Alexander Lobakin
2021-01-10 11:56   ` [PATCH v5 mips-next 3/9] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS Alexander Lobakin
2021-01-10 11:56   ` [PATCH v5 mips-next 4/9] MIPS: properly stop .eh_frame generation Alexander Lobakin
2021-01-10 11:56   ` Alexander Lobakin [this message]
2021-01-11  1:28     ` [PATCH v5 mips-next 5/9] MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols Nathan Chancellor
2021-01-10 11:56   ` [PATCH v5 mips-next 6/9] MIPS: vmlinux.lds.S: explicitly declare .got table Alexander Lobakin
2021-01-10 11:56   ` [PATCH v5 mips-next 7/9] vmlinux.lds.h: catch compound literals into data and BSS Alexander Lobakin
2021-01-10 11:56   ` [PATCH v5 mips-next 8/9] vmlinux.lds.h: catch UBSAN's "unnamed data" into data Alexander Lobakin
2021-01-11  2:05     ` Nathan Chancellor
2021-01-10 11:57   ` [PATCH v5 mips-next 9/9] MIPS: select ARCH_WANT_LD_ORPHAN_WARN Alexander Lobakin
2021-01-11 19:53 ` [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup Kees Cook
2021-01-11 20:57   ` Alexander Lobakin
2021-01-11 22:43     ` Thomas Bogendoerfer
2021-01-15 11:15       ` Arnd Bergmann
2021-01-15 14:40 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210110115546.30970-5-alobakin@pm.me \
    --to=alobakin@pm.me \
    --cc=arnd@arndb.de \
    --cc=chenhuacai@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=cminyard@mvista.com \
    --cc=huangpei@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=keescook@chromium.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=maskray@google.com \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=ralf@linux-mips.org \
    --cc=stable@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).