From: Alexander Lobakin <alobakin@pm.me>
To: Kees Cook <keescook@chromium.org>
Cc: Alexander Lobakin <alobakin@pm.me>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Huacai Chen <chenhuacai@kernel.org>,
Pei Huang <huangpei@loongson.cn>,
Fangrui Song <maskray@google.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Ralf Baechle <ralf@linux-mips.org>,
Corey Minyard <cminyard@mvista.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, stable@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup
Date: Mon, 11 Jan 2021 20:57:25 +0000 [thread overview]
Message-ID: <20210111205649.18263-1-alobakin@pm.me> (raw)
In-Reply-To: <202101111153.AE5123B6@keescook>
From: Kees Cook <keescook@chromium.org>
Date: Mon, 11 Jan 2021 11:53:39 -0800
> On Sun, Jan 10, 2021 at 11:53:50AM +0000, Alexander Lobakin wrote:
>> This series hunts the problems discovered after manual enabling of
>> ARCH_WANT_LD_ORPHAN_WARN. Notably:
>> - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO
>> placement (marked for stable);
>> - stops blind catching of orphan text sections with .text.*
>> directive;
>> - properly stops .eh_frame section generation.
>>
>> Compile and runtime tested on MIPS32R2 CPS board with no issues
>> using two different toolkits:
>> - Binutils 2.35.1, GCC 10.2.1 (with Alpine patches);
>> - LLVM stack: 11.0.0 and from latest Git snapshot.
>>
>> Since v4 [3]:
>> - new: drop redundant .text.cps-vec creation and blind inclusion
>> of orphan text sections via .text.* directive in vmlinux.lds.S;
>> - don't assert SIZEOF(.rel.dyn) as it's reported that it may be not
>> empty on certain machines and compilers (Thomas);
>> - align GOT table like it's done for ARM64;
>> - new: catch UBSAN's "unnamed data" sections in generic definitions
>> when building with LD_DEAD_CODE_DATA_ELIMINATION;
>> - collect Reviewed-bys (Kees, Nathan).
>
> Looks good; which tree will this land through?
linux-mips/mips-next I guess, since 7 of 9 patches are related only
to this architecture.
This might need Arnd's Acked-bys or Reviewed-by for the two that
refer include/asm-generic, let's see what Thomas think.
> -Kees
>
>>
>> Since v3 [2]:
>> - fix the third patch as GNU stack emits .rel.dyn into VDSO for
>> some reason if .cfi_sections is specified.
>>
>> Since v2 [1]:
>> - stop discarding .eh_frame and just prevent it from generating
>> (Kees);
>> - drop redundant sections assertions (Fangrui);
>> - place GOT table in .text instead of asserting as it's not empty
>> when building with LLVM (Nathan);
>> - catch compound literals in generic definitions when building with
>> LD_DEAD_CODE_DATA_ELIMINATION (Kees);
>> - collect two Reviewed-bys (Kees).
>>
>> Since v1 [0]:
>> - catch .got entries too as LLD may produce it (Nathan);
>> - check for unwanted sections to be zero-sized instead of
>> discarding (Fangrui).
>>
>> [0] https://lore.kernel.org/linux-mips/20210104121729.46981-1-alobakin@pm.me
>> [1] https://lore.kernel.org/linux-mips/20210106200713.31840-1-alobakin@pm.me
>> [2] https://lore.kernel.org/linux-mips/20210107115120.281008-1-alobakin@pm.me
>> [3] https://lore.kernel.org/linux-mips/20210107123331.354075-1-alobakin@pm.me
>>
>> Alexander Lobakin (9):
>> MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section
>> MIPS: CPS: don't create redundant .text.cps-vec section
>> MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS
>> MIPS: properly stop .eh_frame generation
>> MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols
>> MIPS: vmlinux.lds.S: explicitly declare .got table
>> vmlinux.lds.h: catch compound literals into data and BSS
>> vmlinux.lds.h: catch UBSAN's "unnamed data" into data
>> MIPS: select ARCH_WANT_LD_ORPHAN_WARN
>>
>> arch/mips/Kconfig | 1 +
>> arch/mips/include/asm/asm.h | 18 ++++++++++++++++++
>> arch/mips/kernel/cps-vec.S | 1 -
>> arch/mips/kernel/vmlinux.lds.S | 11 +++++++++--
>> include/asm-generic/vmlinux.lds.h | 6 +++---
>> 5 files changed, 31 insertions(+), 6 deletions(-)
>>
>> --
>> 2.30.0
>>
>>
>
> --
> Kees Cook
Al
next prev parent reply other threads:[~2021-01-11 20:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 11:53 [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 1/9] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 2/9] MIPS: CPS: don't create redundant .text.cps-vec section Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 3/9] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 4/9] MIPS: properly stop .eh_frame generation Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 5/9] MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols Alexander Lobakin
2021-01-11 1:28 ` Nathan Chancellor
2021-01-10 11:56 ` [PATCH v5 mips-next 6/9] MIPS: vmlinux.lds.S: explicitly declare .got table Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 7/9] vmlinux.lds.h: catch compound literals into data and BSS Alexander Lobakin
2021-01-10 11:56 ` [PATCH v5 mips-next 8/9] vmlinux.lds.h: catch UBSAN's "unnamed data" into data Alexander Lobakin
2021-01-11 2:05 ` Nathan Chancellor
2021-01-10 11:57 ` [PATCH v5 mips-next 9/9] MIPS: select ARCH_WANT_LD_ORPHAN_WARN Alexander Lobakin
2021-01-11 19:53 ` [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup Kees Cook
2021-01-11 20:57 ` Alexander Lobakin [this message]
2021-01-11 22:43 ` Thomas Bogendoerfer
2021-01-15 11:15 ` Arnd Bergmann
2021-01-15 14:40 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111205649.18263-1-alobakin@pm.me \
--to=alobakin@pm.me \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=cminyard@mvista.com \
--cc=huangpei@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).