* drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
@ 2021-01-11 10:43 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-01-11 10:43 UTC (permalink / raw)
To: kbuild, Amit Sunil Dhamne
Cc: lkp, kbuild-all, linux-kernel, Michal Simek, Ravi Patel,
Rajan Vaja, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f5e6c330254ae691f6d7befe61c786eb5056007e
commit: acfdd18591eaac25446e976a0c0d190f8b3dbfb1 firmware: xilinx: Use hash-table for api feature check
config: arm64-randconfig-m031-20210108 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
vim +/feature_data +1288 drivers/firmware/xilinx/zynqmp.c
76582671eb5d006 Rajan Vaja 2018-09-12 1280 static int zynqmp_firmware_remove(struct platform_device *pdev)
76582671eb5d006 Rajan Vaja 2018-09-12 1281 {
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1282 struct pm_api_feature_data *feature_data;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1283 int i;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1284
e23d9c6d0d4912f Jolly Shah 2019-02-01 1285 mfd_remove_devices(&pdev->dev);
b321725257c1733 Rajan Vaja 2018-09-12 1286 zynqmp_pm_api_debugfs_exit();
b321725257c1733 Rajan Vaja 2018-09-12 1287
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 @1288 hash_for_each(pm_api_features_map, i, feature_data, hentry) {
This has to use hash_for_each_safe().
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1289 hash_del(&feature_data->hentry);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1290 kfree(feature_data);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1291 }
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1292
76582671eb5d006 Rajan Vaja 2018-09-12 1293 return 0;
76582671eb5d006 Rajan Vaja 2018-09-12 1294 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31707 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-11 10:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 10:43 drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data' Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).