From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Bjarni Jonasson <bjarni.jonasson@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v1 2/2] sfp: add support for 100 base-x SFPs
Date: Mon, 11 Jan 2021 14:22:45 +0000 [thread overview]
Message-ID: <20210111142245.GW1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210111130657.10703-3-bjarni.jonasson@microchip.com>
On Mon, Jan 11, 2021 at 02:06:57PM +0100, Bjarni Jonasson wrote:
> Add support for 100Base-FX, 100Base-LX, 100Base-PX and 100Base-BX10 modules
> This is needed for Sparx-5 switch.
>
> Signed-off-by: Bjarni Jonasson <bjarni.jonasson@microchip.com>
> ---
> drivers/net/phy/sfp-bus.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
> index 58014feedf6c..b2a9ee3dd28e 100644
> --- a/drivers/net/phy/sfp-bus.c
> +++ b/drivers/net/phy/sfp-bus.c
> @@ -265,6 +265,12 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
> br_min <= 1300 && br_max >= 1200)
> phylink_set(modes, 1000baseX_Full);
>
> + /* 100Base-FX, 100Base-LX, 100Base-PX, 100Base-BX10 */
> + if (id->base.e100_base_fx || id->base.e100_base_lx)
> + phylink_set(modes, 100baseFX_Full);
> + if ((id->base.e_base_px || id->base.e_base_bx10) && br_nom == 100)
> + phylink_set(modes, 100baseFX_Full);
Do you have any modules that identify as PX or BX10 modules? What if
their range of speeds covers 100M - you're only checking the nominal
speed here.
Note that this will likely conflict with changes I submitted over the
weekend, and it really needs to be done _before_ the comment about
"If we haven't discovered any modes", not below.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-01-11 14:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 13:06 [PATCH v1 0/2] Add 100 base-x mode Bjarni Jonasson
2021-01-11 13:06 ` [PATCH v1 1/2] net: phy: " Bjarni Jonasson
2021-01-11 14:19 ` Russell King - ARM Linux admin
2021-01-11 14:26 ` Andrew Lunn
2021-01-11 16:47 ` Russell King - ARM Linux admin
2021-01-12 15:32 ` Bjarni Jonasson
2021-01-11 19:37 ` Michał Mirosław
2021-01-12 15:34 ` Bjarni Jonasson
2021-01-11 13:06 ` [PATCH v1 2/2] sfp: add support for 100 base-x SFPs Bjarni Jonasson
2021-01-11 14:22 ` Russell King - ARM Linux admin [this message]
2021-01-12 15:31 ` Bjarni Jonasson
2021-01-12 15:39 ` Andrew Lunn
2021-01-11 14:18 ` [PATCH v1 0/2] Add 100 base-x mode Russell King - ARM Linux admin
2021-01-12 14:33 ` Bjarni Jonasson
2021-01-12 16:05 ` Russell King - ARM Linux admin
2021-01-13 9:45 ` Bjarni Jonasson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111142245.GW1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).