From: Bjarni Jonasson <bjarni.jonasson@microchip.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
Date: Tue, 12 Jan 2021 16:34:19 +0100 [thread overview]
Message-ID: <4080678764ff0abfb7491e9b34fc4f46bf3262a8.camel@microchip.com> (raw)
In-Reply-To: <CAHXqBFJSgebLn9GxgdYGdVR6_+i76uX5YyjHw5niOet9BuYj6A@mail.gmail.com>
On Mon, 2021-01-11 at 20:37 +0100, Michał Mirosław wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> pon., 11 sty 2021 o 14:54 Bjarni Jonasson
> <bjarni.jonasson@microchip.com> napisał(a):
> > Sparx-5 supports this mode and it is missing in the PHY core.
> >
> > Signed-off-by: Bjarni Jonasson <bjarni.jonasson@microchip.com>
> > ---
> > include/linux/phy.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/phy.h b/include/linux/phy.h
> > index 56563e5e0dc7..dce867222d58 100644
> > --- a/include/linux/phy.h
> > +++ b/include/linux/phy.h
> > @@ -111,6 +111,7 @@ extern const int phy_10gbit_features_array[1];
> > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR
> > * @PHY_INTERFACE_MODE_USXGMII: Universal Serial 10GE MII
> > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN
> > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX
> > * @PHY_INTERFACE_MODE_MAX: Book keeping
>
> [...]
>
> This is kernel-internal interface, so maybe the new mode can be
> inserted before 1000baseX for easier lookup?
>
> Best Regards
> Michał Mirosław
Yes, will do that.
--
Bjarni Jonasson
Microchip
next prev parent reply other threads:[~2021-01-12 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 13:06 [PATCH v1 0/2] Add 100 base-x mode Bjarni Jonasson
2021-01-11 13:06 ` [PATCH v1 1/2] net: phy: " Bjarni Jonasson
2021-01-11 14:19 ` Russell King - ARM Linux admin
2021-01-11 14:26 ` Andrew Lunn
2021-01-11 16:47 ` Russell King - ARM Linux admin
2021-01-12 15:32 ` Bjarni Jonasson
2021-01-11 19:37 ` Michał Mirosław
2021-01-12 15:34 ` Bjarni Jonasson [this message]
2021-01-11 13:06 ` [PATCH v1 2/2] sfp: add support for 100 base-x SFPs Bjarni Jonasson
2021-01-11 14:22 ` Russell King - ARM Linux admin
2021-01-12 15:31 ` Bjarni Jonasson
2021-01-12 15:39 ` Andrew Lunn
2021-01-11 14:18 ` [PATCH v1 0/2] Add 100 base-x mode Russell King - ARM Linux admin
2021-01-12 14:33 ` Bjarni Jonasson
2021-01-12 16:05 ` Russell King - ARM Linux admin
2021-01-13 9:45 ` Bjarni Jonasson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4080678764ff0abfb7491e9b34fc4f46bf3262a8.camel@microchip.com \
--to=bjarni.jonasson@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).