* [PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup
@ 2021-01-12 9:13 menglong8.dong
2021-01-12 13:02 ` Aurélien Aptel
0 siblings, 1 reply; 2+ messages in thread
From: menglong8.dong @ 2021-01-12 9:13 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, Menglong Dong
From: Menglong Dong <dong.menglong@zte.com.cn>
'rc' in smb3_fs_context_dup is not used and can be removed.
Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
---
fs/cifs/fs_context.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index 0afccbbed2e6..076bcadc756a 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -303,8 +303,6 @@ do { \
int
smb3_fs_context_dup(struct smb3_fs_context *new_ctx, struct smb3_fs_context *ctx)
{
- int rc = 0;
-
memcpy(new_ctx, ctx, sizeof(*ctx));
new_ctx->prepath = NULL;
new_ctx->mount_options = NULL;
@@ -327,7 +325,7 @@ smb3_fs_context_dup(struct smb3_fs_context *new_ctx, struct smb3_fs_context *ctx
DUP_CTX_STR(nodename);
DUP_CTX_STR(iocharset);
- return rc;
+ return 0;
}
static int
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup
2021-01-12 9:13 [PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup menglong8.dong
@ 2021-01-12 13:02 ` Aurélien Aptel
0 siblings, 0 replies; 2+ messages in thread
From: Aurélien Aptel @ 2021-01-12 13:02 UTC (permalink / raw)
To: menglong8.dong, sfrench
Cc: linux-cifs, samba-technical, linux-kernel, Menglong Dong
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Thanks,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 9:13 [PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup menglong8.dong
2021-01-12 13:02 ` Aurélien Aptel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).