* [PATCH v3 1/2] regulator: mt6358: Add OF match table
@ 2021-01-12 10:06 matthias.bgg
2021-01-12 10:06 ` [PATCH v3 2/2] regulator: mt6323: " matthias.bgg
2021-01-12 13:52 ` [PATCH v3 1/2] regulator: mt6358: " Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: matthias.bgg @ 2021-01-12 10:06 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Hsin-Hsiung Wang, Axel Lin, Chen Zhong, Gene Chen, linux-kernel,
linux-mediatek, linux-arm-kernel, Matthias Brugger,
Matti Vaittinen, Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The binding documentation mentions that a compatible is required for the
MT6358 device node. But the driver does not provide a OF match table.
This way auto-loading is broken as the MFD driver that registers the
device has a .of_compatible set which makes the platform .uevent
callback report a OF modalias, but that's not in the module.
Fixes: f67ff1bd58f0 ("regulator: mt6358: Add support for MT6358 regulator")
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
Changes in v3:
- drop mt6360 patch
Changes in v2:
- check for CONFIG_OF
- add Fixes tag
drivers/regulator/mt6358-regulator.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c
index 13cb6ac9a892..a4ed19a54ec6 100644
--- a/drivers/regulator/mt6358-regulator.c
+++ b/drivers/regulator/mt6358-regulator.c
@@ -534,9 +534,18 @@ static const struct platform_device_id mt6358_platform_ids[] = {
};
MODULE_DEVICE_TABLE(platform, mt6358_platform_ids);
+#ifdef CONFIG_OF
+static const struct of_device_id mt6358_of_match[] = {
+ { .compatible = "mediatek,mt6358-regulator", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mt6358_of_match);
+#endif
+
static struct platform_driver mt6358_regulator_driver = {
.driver = {
.name = "mt6358-regulator",
+ .of_match_table = of_match_ptr(mt6358_of_match),
},
.probe = mt6358_regulator_probe,
.id_table = mt6358_platform_ids,
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] regulator: mt6323: Add OF match table
2021-01-12 10:06 [PATCH v3 1/2] regulator: mt6358: Add OF match table matthias.bgg
@ 2021-01-12 10:06 ` matthias.bgg
2021-01-12 13:52 ` [PATCH v3 1/2] regulator: mt6358: " Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: matthias.bgg @ 2021-01-12 10:06 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Hsin-Hsiung Wang, Axel Lin, Chen Zhong, Gene Chen, linux-kernel,
linux-mediatek, linux-arm-kernel, Matthias Brugger,
Matti Vaittinen, Matthias Brugger, John Crispin
From: Matthias Brugger <mbrugger@suse.com>
The binding documentation mentions that a compatible is required for the
MT6323 device node. But the driver does not provide a OF match table.
This way auto-loading is broken as the MFD driver that registers the
device has a .of_compatible set which makes the platform .uevent
callback report a OF modalias, but that's not in the module.
Fixes: 2fdf82923618 ("regulator: mt6323: Add support for MT6323 regulator")
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
Changes in v3: None
Changes in v2:
- check for CONFIG_OF
- add Fixes tag
drivers/regulator/mt6323-regulator.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c
index ff9016170db3..646742d4db74 100644
--- a/drivers/regulator/mt6323-regulator.c
+++ b/drivers/regulator/mt6323-regulator.c
@@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = {
};
MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
+#ifdef CONFIG_OF
+static const struct of_device_id mt6323_of_match[] = {
+ { .compatible = "mediatek,mt6323-regulator", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mt6323_of_match);
+#endif
+
static struct platform_driver mt6323_regulator_driver = {
.driver = {
.name = "mt6323-regulator",
+ .of_match_table = of_match_ptr(mt6323_of_match),
},
.probe = mt6323_regulator_probe,
.id_table = mt6323_platform_ids,
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/2] regulator: mt6358: Add OF match table
2021-01-12 10:06 [PATCH v3 1/2] regulator: mt6358: Add OF match table matthias.bgg
2021-01-12 10:06 ` [PATCH v3 2/2] regulator: mt6323: " matthias.bgg
@ 2021-01-12 13:52 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-01-12 13:52 UTC (permalink / raw)
To: matthias.bgg
Cc: Liam Girdwood, Hsin-Hsiung Wang, Axel Lin, Chen Zhong, Gene Chen,
linux-kernel, linux-mediatek, linux-arm-kernel, Matthias Brugger,
Matti Vaittinen, Matthias Brugger
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On Tue, Jan 12, 2021 at 11:06:57AM +0100, matthias.bgg@kernel.org wrote:
> The binding documentation mentions that a compatible is required for the
> MT6358 device node. But the driver does not provide a OF match table.
> This way auto-loading is broken as the MFD driver that registers the
> device has a .of_compatible set which makes the platform .uevent
> callback report a OF modalias, but that's not in the module.
As previously discussed it'd be better to fix the binding document to
deprecate the requirement for the compatible and remove the usage from
the MFD.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 10:06 [PATCH v3 1/2] regulator: mt6358: Add OF match table matthias.bgg
2021-01-12 10:06 ` [PATCH v3 2/2] regulator: mt6323: " matthias.bgg
2021-01-12 13:52 ` [PATCH v3 1/2] regulator: mt6358: " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).