* [PATCH 1/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
@ 2021-01-12 23:15 ` Andreas Kemnade
2021-01-12 23:15 ` [PATCH 2/4] ARM: dts: imx6sl-tolino-shine2hd: add second uart Andreas Kemnade
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-12 23:15 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
Cc: Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by
uboot. While at it, also document the location.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index caa279608803..e17c75c360f2 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -396,7 +396,7 @@
pinctrl_uart1: uart1grp {
fsl,pins = <
MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
- MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
+ MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
>;
};
@@ -543,6 +543,7 @@
};
&uart1 {
+ /* J4, through-holes */
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
status = "okay";
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/4] ARM: dts: imx6sl-tolino-shine2hd: add second uart
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
2021-01-12 23:15 ` [PATCH 1/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
@ 2021-01-12 23:15 ` Andreas Kemnade
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-12 23:15 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
Cc: Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and
kernel, enable it and document its location.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index e17c75c360f2..6ea5f918d059 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -340,7 +340,6 @@
MX6SL_PAD_KEY_ROW7__GPIO4_IO07 0x79
MX6SL_PAD_ECSPI2_MOSI__GPIO4_IO13 0x79
MX6SL_PAD_KEY_COL5__GPIO4_IO02 0x79
- MX6SL_PAD_KEY_ROW6__GPIO4_IO05 0x79
>;
};
@@ -400,6 +399,13 @@
>;
};
+ pinctrl_uart4: uart4grp {
+ fsl,pins = <
+ MX6SL_PAD_KEY_ROW6__UART4_TX_DATA 0x1b0b1
+ MX6SL_PAD_KEY_COL6__UART4_RX_DATA 0x1b0b1
+ >;
+ };
+
pinctrl_usbotg1: usbotg1grp {
fsl,pins = <
MX6SL_PAD_EPDC_PWRCOM__USB_OTG1_ID 0x17059
@@ -549,6 +555,13 @@
status = "okay";
};
+&uart4 {
+ /* TP198, next to J4, SMD pads */
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart4>;
+ status = "okay";
+};
+
&usdhc2 {
pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
pinctrl-0 = <&pinctrl_usdhc2>;
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
2021-01-12 23:15 ` [PATCH 1/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
2021-01-12 23:15 ` [PATCH 2/4] ARM: dts: imx6sl-tolino-shine2hd: add second uart Andreas Kemnade
@ 2021-01-12 23:15 ` Andreas Kemnade
2021-01-13 12:39 ` [Letux-kernel] " H. Nikolaus Schaller
2021-01-13 13:28 ` Andreas Kemnade
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: " Andreas Kemnade
` (2 subsequent siblings)
5 siblings, 2 replies; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-12 23:15 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
Cc: Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by
uboot. While at it, also document the location.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
index 27143ea0f0f1..62d2ebda04ff 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
@@ -156,7 +156,7 @@
pinctrl_uart1: uart1grp {
fsl,pins = <
MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
- MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
+ MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Letux-kernel] [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
@ 2021-01-13 12:39 ` H. Nikolaus Schaller
2021-01-13 13:28 ` Andreas Kemnade
1 sibling, 0 replies; 10+ messages in thread
From: H. Nikolaus Schaller @ 2021-01-13 12:39 UTC (permalink / raw)
To: Discussions about the Letux Kernel
Cc: Rob Herring, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer
> Am 13.01.2021 um 00:15 schrieb Andreas Kemnade <andreas@kemnade.info>:
>
> Configuration was correct enough to work with the pre-configuration done by
> uboot. While at it, also document the location.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +-
seems to have a typo (shine2hd vs. shine3) in the patch subject.
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> index 27143ea0f0f1..62d2ebda04ff 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -156,7 +156,7 @@
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
> - MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
> + MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
> >;
> };
>
> --
> 2.20.1
>
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
2021-01-13 12:39 ` [Letux-kernel] " H. Nikolaus Schaller
@ 2021-01-13 13:28 ` Andreas Kemnade
1 sibling, 0 replies; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-13 13:28 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
please ignore, that was accidentially sent.
On Wed, 13 Jan 2021 00:15:47 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:
> Configuration was correct enough to work with the pre-configuration done by
> uboot. While at it, also document the location.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> index 27143ea0f0f1..62d2ebda04ff 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -156,7 +156,7 @@
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
> - MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
> + MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
> >;
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: correct console uart pinmux
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
` (2 preceding siblings ...)
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux Andreas Kemnade
@ 2021-01-12 23:15 ` Andreas Kemnade
2021-01-13 12:40 ` [Letux-kernel] " H. Nikolaus Schaller
2021-01-12 23:15 ` [PATCH 4/4] ARM: dts: imx: e60k02: add second uart Andreas Kemnade
2021-01-18 7:12 ` [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Shawn Guo
5 siblings, 1 reply; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-12 23:15 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
Cc: Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by
uboot. While at it, also document the location.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
index 27143ea0f0f1..62d2ebda04ff 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
@@ -156,7 +156,7 @@
pinctrl_uart1: uart1grp {
fsl,pins = <
MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
- MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
+ MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Letux-kernel] [PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: correct console uart pinmux
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: " Andreas Kemnade
@ 2021-01-13 12:40 ` H. Nikolaus Schaller
0 siblings, 0 replies; 10+ messages in thread
From: H. Nikolaus Schaller @ 2021-01-13 12:40 UTC (permalink / raw)
To: Discussions about the Letux Kernel
Cc: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer
Ah, there is a v2. Let's hope this gets merged/processed by robots correctly :)
> Am 13.01.2021 um 00:15 schrieb Andreas Kemnade <andreas@kemnade.info>:
>
> Configuration was correct enough to work with the pre-configuration done by
> uboot. While at it, also document the location.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> index 27143ea0f0f1..62d2ebda04ff 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -156,7 +156,7 @@
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
> - MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
> + MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
> >;
> };
>
> --
> 2.20.1
>
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/4] ARM: dts: imx: e60k02: add second uart
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
` (3 preceding siblings ...)
2021-01-12 23:15 ` [PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: " Andreas Kemnade
@ 2021-01-12 23:15 ` Andreas Kemnade
2021-01-18 7:12 ` [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Shawn Guo
5 siblings, 0 replies; 10+ messages in thread
From: Andreas Kemnade @ 2021-01-12 23:15 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, j.neuschaefer,
letux-kernel
Cc: Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and
kernel, enable it and document its location.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/e60k02.dtsi | 6 ++++++
arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 13 ++++++++++++-
arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 13 ++++++++++++-
3 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
index 3af1ab4458ef..cfb239d5186a 100644
--- a/arch/arm/boot/dts/e60k02.dtsi
+++ b/arch/arm/boot/dts/e60k02.dtsi
@@ -278,6 +278,12 @@
};
&uart1 {
+ /* J4, through-hole */
+ status = "okay";
+};
+
+&uart4 {
+ /* TP198, next to J4, SMD pads */
status = "okay";
};
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
index 62d2ebda04ff..e3f1e8d79528 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
@@ -94,7 +94,6 @@
MX6SL_PAD_KEY_ROW7__GPIO4_IO07 0x79
MX6SL_PAD_ECSPI2_MOSI__GPIO4_IO13 0x79
MX6SL_PAD_KEY_COL5__GPIO4_IO02 0x79
- MX6SL_PAD_KEY_ROW6__GPIO4_IO05 0x79
>;
};
@@ -160,6 +159,13 @@
>;
};
+ pinctrl_uart4: uart4grp {
+ fsl,pins = <
+ MX6SL_PAD_KEY_ROW6__UART4_TX_DATA 0x1b0b1
+ MX6SL_PAD_KEY_COL6__UART4_RX_DATA 0x1b0b1
+ >;
+ };
+
pinctrl_usbotg1: usbotg1grp {
fsl,pins = <
MX6SL_PAD_EPDC_PWRCOM__USB_OTG1_ID 0x17059
@@ -300,6 +306,11 @@
pinctrl-0 = <&pinctrl_uart1>;
};
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart4>;
+};
+
&usdhc2 {
pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
pinctrl-0 = <&pinctrl_usdhc2>;
diff --git a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
index 7214d1c98249..90b32f5eb529 100644
--- a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
+++ b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
@@ -104,7 +104,6 @@
MX6SLL_PAD_KEY_ROW7__GPIO4_IO07 0x79
MX6SLL_PAD_ECSPI2_MOSI__GPIO4_IO13 0x79
MX6SLL_PAD_KEY_COL5__GPIO4_IO02 0x79
- MX6SLL_PAD_KEY_ROW6__GPIO4_IO05 0x79
>;
};
@@ -170,6 +169,13 @@
>;
};
+ pinctrl_uart4: uart4grp {
+ fsl,pins = <
+ MX6SLL_PAD_KEY_ROW6__UART4_DCE_TX 0x1b0b1
+ MX6SLL_PAD_KEY_COL6__UART4_DCE_RX 0x1b0b1
+ >;
+ };
+
pinctrl_usbotg1: usbotg1grp {
fsl,pins = <
MX6SLL_PAD_EPDC_PWR_COM__USB_OTG1_ID 0x17059
@@ -302,6 +308,11 @@
pinctrl-0 = <&pinctrl_uart1>;
};
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart4>;
+};
+
&usdhc2 {
pinctrl-names = "default", "state_100mhz", "state_200mhz","sleep";
pinctrl-0 = <&pinctrl_usdhc2>;
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders
2021-01-12 23:15 [PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders Andreas Kemnade
` (4 preceding siblings ...)
2021-01-12 23:15 ` [PATCH 4/4] ARM: dts: imx: e60k02: add second uart Andreas Kemnade
@ 2021-01-18 7:12 ` Shawn Guo
5 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2021-01-18 7:12 UTC (permalink / raw)
To: Andreas Kemnade
Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree,
linux-kernel, linux-arm-kernel, j.neuschaefer, letux-kernel
On Wed, Jan 13, 2021 at 12:15:44AM +0100, Andreas Kemnade wrote:
> - add second uart
> - correct pinmux for console uart (it was working before because of
> setup by uboot)
> - document locations on board
>
> Andreas Kemnade (4):
> ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux
> ARM: dts: imx6sl-tolino-shine2hd: add second uart
> ARM: dts: imx6sl-tolino-shine3: correct console uart pinmux
> ARM: dts: imx: e60k02: add second uart
Applied all, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread