* [PATCH v2 1/2] arm64: dts: mt8183: config dsi node
@ 2021-01-07 5:22 Hsin-Yi Wang
2021-01-07 5:22 ` [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang
2021-01-07 5:26 ` [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Nicolas Boichat
0 siblings, 2 replies; 5+ messages in thread
From: Hsin-Yi Wang @ 2021-01-07 5:22 UTC (permalink / raw)
To: linux-arm-kernel, Matthias Brugger
Cc: Rob Herring, Enric Balletbo i Serra, Nicolas Boichat, devicetree,
linux-mediatek, linux-kernel
Config dsi node for mt8183 kukui. Set panel and ports.
Several kukui boards share the same panel property and only compatible
is different. So compatible will be set in board dts for comparison
convenience.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Change:
v2: move compatible to board dts
---
.../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
index 47113e275cb52..721d16f9c3b4f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
@@ -16,3 +16,8 @@ / {
model = "MediaTek krane sku176 board";
compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183";
};
+
+&panel {
+ status = "okay";
+ compatible = "boe,tv101wum-nl6";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index bf2ad1294dd30..d3d20e4773cf1 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -249,6 +249,35 @@ &cpu7 {
proc-supply = <&mt6358_vproc11_reg>;
};
+&dsi0 {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel: panel@0 {
+ // compatible will be set in board dts
+ reg = <0>;
+ enable-gpios = <&pio 45 0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&panel_pins_default>;
+ avdd-supply = <&ppvarn_lcd>;
+ avee-supply = <&ppvarp_lcd>;
+ pp1800-supply = <&pp1800_lcd>;
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi_out>;
+ };
+ };
+ };
+
+ ports {
+ port {
+ dsi_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+};
+
&i2c0 {
pinctrl-names = "default";
pinctrl-0 = <&i2c0_pins>;
@@ -547,6 +576,14 @@ pins_clk {
};
};
+ panel_pins_default: panel_pins_default {
+ panel_reset {
+ pinmux = <PINMUX_GPIO45__FUNC_GPIO45>;
+ output-low;
+ bias-pull-up;
+ };
+ };
+
pwm0_pin_default: pwm0_pin_default {
pins1 {
pinmux = <PINMUX_GPIO176__FUNC_GPIO176>;
--
2.29.2.729.g45daf8777d-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
2021-01-07 5:22 [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Hsin-Yi Wang
@ 2021-01-07 5:22 ` Hsin-Yi Wang
2021-01-13 3:20 ` Rob Herring
2021-01-07 5:26 ` [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Nicolas Boichat
1 sibling, 1 reply; 5+ messages in thread
From: Hsin-Yi Wang @ 2021-01-07 5:22 UTC (permalink / raw)
To: linux-arm-kernel, Matthias Brugger
Cc: Rob Herring, Enric Balletbo i Serra, Nicolas Boichat, devicetree,
linux-mediatek, linux-kernel
Similar to krane-sku176 but using a different panel source.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Change:
v2: move compatible to board dts
---
.../devicetree/bindings/arm/mediatek.yaml | 1 +
arch/arm64/boot/dts/mediatek/Makefile | 1 +
.../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
3 files changed, 25 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 53f0d4e3ea982..3276f7a2ce672 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -120,6 +120,7 @@ properties:
- const: mediatek,mt8183
- description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
items:
+ - const: google,krane-sku0
- const: google,krane-sku176
- const: google,krane
- const: mediatek,mt8183
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 18f7b46c4095b..deba27ab76574 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
new file mode 100644
index 0000000000000..fb5ee91b6fe0e
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2019 Google LLC
+ *
+ * Device-tree for Krane sku0.
+ *
+ * SKU is a 8-bit value (0x00 == 0):
+ * - Bits 7..4: Panel ID: 0x0 (AUO)
+ * - Bits 3..0: SKU ID: 0x0 (default)
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-krane.dtsi"
+
+/ {
+ model = "MediaTek krane sku0 board";
+ compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183";
+};
+
+&panel {
+ status = "okay";
+ compatible = "auo,kd101n80-45na";
+};
--
2.29.2.729.g45daf8777d-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: mt8183: config dsi node
2021-01-07 5:22 [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Hsin-Yi Wang
2021-01-07 5:22 ` [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang
@ 2021-01-07 5:26 ` Nicolas Boichat
1 sibling, 0 replies; 5+ messages in thread
From: Nicolas Boichat @ 2021-01-07 5:26 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm Mailing List, Matthias Brugger, Rob Herring,
Enric Balletbo i Serra, Devicetree List,
moderated list:ARM/Mediatek SoC support, lkml
On Thu, Jan 7, 2021 at 1:22 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Config dsi node for mt8183 kukui. Set panel and ports.
>
> Several kukui boards share the same panel property and only compatible
> is different. So compatible will be set in board dts for comparison
> convenience.
I like this, but maybe others have different opinions ,-)
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v2: move compatible to board dts
> ---
> .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++
> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
> index 47113e275cb52..721d16f9c3b4f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
> @@ -16,3 +16,8 @@ / {
> model = "MediaTek krane sku176 board";
> compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183";
> };
> +
> +&panel {
> + status = "okay";
> + compatible = "boe,tv101wum-nl6";
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index bf2ad1294dd30..d3d20e4773cf1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -249,6 +249,35 @@ &cpu7 {
> proc-supply = <&mt6358_vproc11_reg>;
> };
>
> +&dsi0 {
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel: panel@0 {
> + // compatible will be set in board dts
> + reg = <0>;
> + enable-gpios = <&pio 45 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&panel_pins_default>;
> + avdd-supply = <&ppvarn_lcd>;
> + avee-supply = <&ppvarp_lcd>;
> + pp1800-supply = <&pp1800_lcd>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> + };
> +
> + ports {
> + port {
> + dsi_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +};
> +
> &i2c0 {
> pinctrl-names = "default";
> pinctrl-0 = <&i2c0_pins>;
> @@ -547,6 +576,14 @@ pins_clk {
> };
> };
>
> + panel_pins_default: panel_pins_default {
> + panel_reset {
> + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>;
> + output-low;
> + bias-pull-up;
> + };
> + };
> +
> pwm0_pin_default: pwm0_pin_default {
> pins1 {
> pinmux = <PINMUX_GPIO176__FUNC_GPIO176>;
> --
> 2.29.2.729.g45daf8777d-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
2021-01-07 5:22 ` [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang
@ 2021-01-13 3:20 ` Rob Herring
2021-01-13 6:23 ` Hsin-Yi Wang
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-01-13 3:20 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Matthias Brugger, Enric Balletbo i Serra,
Nicolas Boichat, devicetree, linux-mediatek, linux-kernel
On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> Similar to krane-sku176 but using a different panel source.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v2: move compatible to board dts
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> 3 files changed, 25 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 53f0d4e3ea982..3276f7a2ce672 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -120,6 +120,7 @@ properties:
> - const: mediatek,mt8183
> - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> items:
> + - const: google,krane-sku0
> - const: google,krane-sku176
> - const: google,krane
> - const: mediatek,mt8183
This says you must have all 4 compatible strings in the order listed.
That doesn't match your dts. I assume you want the first 2 under an
'enum' so there's 3 strings with the first one being sku0 or sku176?
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
2021-01-13 3:20 ` Rob Herring
@ 2021-01-13 6:23 ` Hsin-Yi Wang
0 siblings, 0 replies; 5+ messages in thread
From: Hsin-Yi Wang @ 2021-01-13 6:23 UTC (permalink / raw)
To: Rob Herring
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Matthias Brugger, Enric Balletbo i Serra, Nicolas Boichat,
Devicetree List, moderated list:ARM/Mediatek SoC support, lkml
On Wed, Jan 13, 2021 at 11:20 AM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> > Similar to krane-sku176 but using a different panel source.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > Change:
> > v2: move compatible to board dts
> > ---
> > .../devicetree/bindings/arm/mediatek.yaml | 1 +
> > arch/arm64/boot/dts/mediatek/Makefile | 1 +
> > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> > 3 files changed, 25 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 53f0d4e3ea982..3276f7a2ce672 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -120,6 +120,7 @@ properties:
> > - const: mediatek,mt8183
> > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> > items:
> > + - const: google,krane-sku0
> > - const: google,krane-sku176
> > - const: google,krane
> > - const: mediatek,mt8183
>
> This says you must have all 4 compatible strings in the order listed.
> That doesn't match your dts. I assume you want the first 2 under an
> 'enum' so there's 3 strings with the first one being sku0 or sku176?
>
Right. I'll fix in the next version. Thanks
> Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-13 6:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 5:22 [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Hsin-Yi Wang
2021-01-07 5:22 ` [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang
2021-01-13 3:20 ` Rob Herring
2021-01-13 6:23 ` Hsin-Yi Wang
2021-01-07 5:26 ` [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Nicolas Boichat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).