* [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C
@ 2021-01-16 21:13 Randy Dunlap
2021-01-17 9:48 ` Martin Mokrejs
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-01-16 21:13 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Sebastian Reichel, linux-pm, Martin Mokrejs,
Greg Kroah-Hartman, nicolassaenzj, Nicolas Saenz Julienne,
Rafael J . Wysocki
CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are
provided by that Kconfig symbol.
Fixes these errors:
../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type
static const struct regmap_config sbs_regmap = {
../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’
.reg_bits = 8,
../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function)
.val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */
../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’:
../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration]
chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap);
../drivers/power/supply/sbs-charger.c: At top level:
../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known
static const struct regmap_config sbs_regmap = {
Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org
Cc: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: nicolassaenzj@gmail.com
Cc: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
---
Martin, do you want Reported-by: on this?
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210115.orig/drivers/power/supply/Kconfig
+++ linux-next-20210115/drivers/power/supply/Kconfig
@@ -229,6 +229,7 @@ config BATTERY_SBS
config CHARGER_SBS
tristate "SBS Compliant charger"
depends on I2C
+ select REGMAP_I2C
help
Say Y to include support for SBS compliant battery chargers.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C
2021-01-16 21:13 [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C Randy Dunlap
@ 2021-01-17 9:48 ` Martin Mokrejs
2021-01-17 18:21 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Martin Mokrejs @ 2021-01-17 9:48 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Sebastian Reichel, linux-pm, Greg Kroah-Hartman, nicolassaenzj,
Nicolas Saenz Julienne, Rafael J . Wysocki
Hi Randy,
thank you very much. I would not mind dropping my name but I tested the patch
now with 5.4.89 so you may actually also add
Tested-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
It also happened with 5.10.7, it is probably obvious.
Thank you for quick action.
Martin
On 16/01/2021 22:13, Randy Dunlap wrote:
> CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are
> provided by that Kconfig symbol.
>
> Fixes these errors:
>
> ../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type
> static const struct regmap_config sbs_regmap = {
> ../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’
> .reg_bits = 8,
> ../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function)
> .val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */
> ../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’:
> ../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration]
> chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap);
> ../drivers/power/supply/sbs-charger.c: At top level:
> ../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known
> static const struct regmap_config sbs_regmap = {
>
> Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: nicolassaenzj@gmail.com
> Cc: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> ---
> Martin, do you want Reported-by: on this?
>
> drivers/power/supply/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210115.orig/drivers/power/supply/Kconfig
> +++ linux-next-20210115/drivers/power/supply/Kconfig
> @@ -229,6 +229,7 @@ config BATTERY_SBS
> config CHARGER_SBS
> tristate "SBS Compliant charger"
> depends on I2C
> + select REGMAP_I2C
> help
> Say Y to include support for SBS compliant battery chargers.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C
2021-01-17 9:48 ` Martin Mokrejs
@ 2021-01-17 18:21 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2021-01-17 18:21 UTC (permalink / raw)
To: Martin Mokrejs
Cc: Randy Dunlap, linux-kernel, linux-pm, Greg Kroah-Hartman,
nicolassaenzj, Nicolas Saenz Julienne, Rafael J . Wysocki
[-- Attachment #1: Type: text/plain, Size: 2719 bytes --]
Hi,
On Sun, Jan 17, 2021 at 10:48:44AM +0100, Martin Mokrejs wrote:
> Hi Randy,
> thank you very much. I would not mind dropping my name but I tested the patch
> now with 5.4.89 so you may actually also add
>
> Tested-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
>
> It also happened with 5.10.7, it is probably obvious.
>
> Thank you for quick action.
> Martin
>
> On 16/01/2021 22:13, Randy Dunlap wrote:
> > CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are
> > provided by that Kconfig symbol.
> >
> > Fixes these errors:
> >
> > ../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type
> > static const struct regmap_config sbs_regmap = {
> > ../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’
> > .reg_bits = 8,
> > ../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function)
> > .val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */
> > ../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’:
> > ../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration]
> > chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap);
> > ../drivers/power/supply/sbs-charger.c: At top level:
> > ../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known
> > static const struct regmap_config sbs_regmap = {
> >
> > Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: linux-pm@vger.kernel.org
> > Cc: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: nicolassaenzj@gmail.com
> > Cc: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > ---
> > Martin, do you want Reported-by: on this?
Thanks, queued. I added Reported-by and Tested-by from Martin.
-- Sebastian
> >
> > drivers/power/supply/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20210115.orig/drivers/power/supply/Kconfig
> > +++ linux-next-20210115/drivers/power/supply/Kconfig
> > @@ -229,6 +229,7 @@ config BATTERY_SBS
> > config CHARGER_SBS
> > tristate "SBS Compliant charger"
> > depends on I2C
> > + select REGMAP_I2C
> > help
> > Say Y to include support for SBS compliant battery chargers.
> >
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-17 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 21:13 [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C Randy Dunlap
2021-01-17 9:48 ` Martin Mokrejs
2021-01-17 18:21 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).