* [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent
@ 2021-01-18 17:25 Isaac Chen
2021-01-19 2:10 ` Tony W Wang-oc
0 siblings, 1 reply; 3+ messages in thread
From: Isaac Chen @ 2021-01-18 17:25 UTC (permalink / raw)
To: TonyWWang-oc; +Cc: linux-kernel, Isaac Chen
This is printed during kernel boot, match it with other supported x86 cpus.
[ 0.000000] KERNEL supported cpus:
[ 0.000000] Intel GenuineIntel
[ 0.000000] AMD AuthenticAMD
[ 0.000000] Hygon HygonGenuine
[ 0.000000] Centaur CentaurHauls
[ 0.000000] zhaoxin Shanghai
Signed-off-by: Isaac Chen <tingyi364@gmail.com>
---
arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
index 05fa4ef63490..f155bbd2aa97 100644
--- a/arch/x86/kernel/cpu/zhaoxin.c
+++ b/arch/x86/kernel/cpu/zhaoxin.c
@@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
#endif
static const struct cpu_dev zhaoxin_cpu_dev = {
- .c_vendor = "zhaoxin",
- .c_ident = { " Shanghai " },
+ .c_vendor = "Zhaoxin",
+ .c_ident = { "Shanghai" },
.c_early_init = early_init_zhaoxin,
.c_init = init_zhaoxin,
#ifdef CONFIG_X86_32
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent
2021-01-18 17:25 [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent Isaac Chen
@ 2021-01-19 2:10 ` Tony W Wang-oc
2021-01-19 5:37 ` [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming Isaac Chen
0 siblings, 1 reply; 3+ messages in thread
From: Tony W Wang-oc @ 2021-01-19 2:10 UTC (permalink / raw)
To: Isaac Chen
Cc: linux-kernel, CobeChen, TimGuo-oc, QiyuanWang, HerryYang, CooperYan
On 19/01/2021 01:25, Isaac Chen wrote:
> This is printed during kernel boot, match it with other supported x86 cpus.
> [ 0.000000] KERNEL supported cpus:
> [ 0.000000] Intel GenuineIntel
> [ 0.000000] AMD AuthenticAMD
> [ 0.000000] Hygon HygonGenuine
> [ 0.000000] Centaur CentaurHauls
> [ 0.000000] zhaoxin Shanghai
>
> Signed-off-by: Isaac Chen <tingyi364@gmail.com>
> ---
> arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
> index 05fa4ef63490..f155bbd2aa97 100644
> --- a/arch/x86/kernel/cpu/zhaoxin.c
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
> #endif
>
> static const struct cpu_dev zhaoxin_cpu_dev = {
> - .c_vendor = "zhaoxin",
> - .c_ident = { " Shanghai " },
> + .c_vendor = "Zhaoxin",
Thanks for this patch.
> + .c_ident = { "Shanghai" },
The Vendor Identification String from CPUID leaf 0x00000000 of Zhaoxin
CPUs is not "Shanghai", ".c_ident = { "Shanghai" }," will cause the
matching of Zhaoxin CPUs fail.
Please do not modify ".c_ident = { " Shanghai " },".
Sincerely,
Tonyw
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming
2021-01-19 2:10 ` Tony W Wang-oc
@ 2021-01-19 5:37 ` Isaac Chen
0 siblings, 0 replies; 3+ messages in thread
From: Isaac Chen @ 2021-01-19 5:37 UTC (permalink / raw)
To: TonyWWang-oc; +Cc: linux-kernel, Isaac Chen
This is printed during kernel boot, match it with other supported x86 cpus.
[ 0.000000] KERNEL supported cpus:
[ 0.000000] Intel GenuineIntel
[ 0.000000] AMD AuthenticAMD
[ 0.000000] Hygon HygonGenuine
[ 0.000000] Centaur CentaurHauls
[ 0.000000] zhaoxin Shanghai
Keep identification string match with CPUID.
Signed-off-by: Isaac Chen <tingyi364@gmail.com>
---
arch/x86/kernel/cpu/zhaoxin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
index 05fa4ef63490..77c33ed80a67 100644
--- a/arch/x86/kernel/cpu/zhaoxin.c
+++ b/arch/x86/kernel/cpu/zhaoxin.c
@@ -120,7 +120,7 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
#endif
static const struct cpu_dev zhaoxin_cpu_dev = {
- .c_vendor = "zhaoxin",
+ .c_vendor = "Zhaoxin",
.c_ident = { " Shanghai " },
.c_early_init = early_init_zhaoxin,
.c_init = init_zhaoxin,
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-19 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 17:25 [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent Isaac Chen
2021-01-19 2:10 ` Tony W Wang-oc
2021-01-19 5:37 ` [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming Isaac Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).