* [PATCH 0/2 v2] HID: fix some kernel-doc notations
@ 2021-01-19 20:07 Randy Dunlap
2021-01-19 20:07 ` [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h> Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-01-19 20:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jiri Kosina, Benjamin Tissoires, linux-input
Clean up kernel-doc notation in 2 <linux/hid*.h> files
and in drivers/hid/hid-quirks.c.
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
rebase & resend:
[PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h>
[PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c
drivers/hid/hid-quirks.c | 25 ++++++++++++++-----------
include/linux/hid-sensor-hub.h | 9 +++++----
include/linux/hid.h | 15 +++++++++++----
3 files changed, 30 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h>
2021-01-19 20:07 [PATCH 0/2 v2] HID: fix some kernel-doc notations Randy Dunlap
@ 2021-01-19 20:07 ` Randy Dunlap
2021-01-19 20:07 ` [PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c Randy Dunlap
2021-01-26 13:24 ` [PATCH 0/2 v2] HID: fix some kernel-doc notations Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-01-19 20:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jiri Kosina, Benjamin Tissoires, linux-input
Correct kernel-doc notation in HID header files (include/linux/hid*.h).
Add notation (comments) where it is missing.
Use the documented "Return:" notation for function return values.
Fix a few typos/spellos.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
---
v2: rebase & resend
include/linux/hid-sensor-hub.h | 9 +++++----
include/linux/hid.h | 15 +++++++++++----
2 files changed, 16 insertions(+), 8 deletions(-)
--- linux-next-20210119.orig/include/linux/hid.h
+++ linux-next-20210119/include/linux/hid.h
@@ -918,7 +918,7 @@ __u32 hid_field_extract(const struct hid
/**
* hid_device_io_start - enable HID input during probe, remove
*
- * @hid - the device
+ * @hid: the device
*
* This should only be called during probe or remove and only be
* called by the thread calling probe or remove. It will allow
@@ -936,7 +936,7 @@ static inline void hid_device_io_start(s
/**
* hid_device_io_stop - disable HID input during probe, remove
*
- * @hid - the device
+ * @hid: the device
*
* Should only be called after hid_device_io_start. It will prevent
* incoming packets from going to the driver for the duration of
@@ -1010,6 +1010,13 @@ static inline void hid_map_usage(struct
/**
* hid_map_usage_clear - map usage input bits and clear the input bit
*
+ * @hidinput: hidinput which we are interested in
+ * @usage: usage to fill in
+ * @bit: pointer to input->{}bit (out parameter)
+ * @max: maximal valid usage->code to consider later (out parameter)
+ * @type: input event type (EV_KEY, EV_REL, ...)
+ * @c: code which corresponds to this usage and type
+ *
* The same as hid_map_usage, except the @c bit is also cleared in supported
* bits (@bit).
*/
@@ -1084,7 +1091,7 @@ static inline void hid_hw_request(struct
* @rtype: HID report type
* @reqtype: HID_REQ_GET_REPORT or HID_REQ_SET_REPORT
*
- * @return: count of data transfered, negative if error
+ * Return: count of data transferred, negative if error
*
* Same behavior as hid_hw_request, but with raw buffers instead.
*/
@@ -1106,7 +1113,7 @@ static inline int hid_hw_raw_request(str
* @buf: raw data to transfer
* @len: length of buf
*
- * @return: count of data transfered, negative if error
+ * Return: count of data transferred, negative if error
*/
static inline int hid_hw_output_report(struct hid_device *hdev, __u8 *buf,
size_t len)
--- linux-next-20210119.orig/include/linux/hid-sensor-hub.h
+++ linux-next-20210119/include/linux/hid-sensor-hub.h
@@ -150,7 +150,7 @@ int sensor_hub_remove_callback(struct hi
* @info: return information about attribute after parsing report
*
* Parses report and returns the attribute information such as report id,
-* field index, units and exponet etc.
+* field index, units and exponent etc.
*/
int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev,
u8 type,
@@ -167,7 +167,7 @@ int sensor_hub_input_get_attribute_info(
* @is_signed: If true then fields < 32 bits will be sign-extended
*
* Issues a synchronous or asynchronous read request for an input attribute.
-* Returns data upto 32 bits.
+* Return: data up to 32 bits.
*/
enum sensor_hub_read_flags {
@@ -205,8 +205,9 @@ int sensor_hub_set_feature(struct hid_se
* @buffer: buffer to copy output
*
* Used to get a field in feature report. For example this can get polling
-* interval, sensitivity, activate/deactivate state. On success it returns
-* number of bytes copied to buffer. On failure, it returns value < 0.
+* interval, sensitivity, activate/deactivate state.
+* Return: On success, it returns the number of bytes copied to buffer.
+* On failure, it returns value < 0.
*/
int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
u32 field_index, int buffer_size, void *buffer);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c
2021-01-19 20:07 [PATCH 0/2 v2] HID: fix some kernel-doc notations Randy Dunlap
2021-01-19 20:07 ` [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h> Randy Dunlap
@ 2021-01-19 20:07 ` Randy Dunlap
2021-01-26 13:24 ` [PATCH 0/2 v2] HID: fix some kernel-doc notations Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-01-19 20:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jiri Kosina, Benjamin Tissoires, linux-input
Use correct kernel-doc notation for functions.
Add notation (comments) where it is missing.
Use the documented "Return:" notation for function return values.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
---
v2: rebase & resend
drivers/hid/hid-quirks.c | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
--- linux-next-20210119.orig/drivers/hid/hid-quirks.c
+++ linux-next-20210119/drivers/hid/hid-quirks.c
@@ -1028,7 +1028,7 @@ static DEFINE_MUTEX(dquirks_lock);
/* Runtime ("dynamic") quirks manipulation functions */
/**
- * hid_exists_dquirk: find any dynamic quirks for a HID device
+ * hid_exists_dquirk - find any dynamic quirks for a HID device
* @hdev: the HID device to match
*
* Description:
@@ -1036,7 +1036,7 @@ static DEFINE_MUTEX(dquirks_lock);
* the pointer to the relevant struct hid_device_id if found.
* Must be called with a read lock held on dquirks_lock.
*
- * Returns: NULL if no quirk found, struct hid_device_id * if found.
+ * Return: NULL if no quirk found, struct hid_device_id * if found.
*/
static struct hid_device_id *hid_exists_dquirk(const struct hid_device *hdev)
{
@@ -1060,7 +1060,7 @@ static struct hid_device_id *hid_exists_
/**
- * hid_modify_dquirk: add/replace a HID quirk
+ * hid_modify_dquirk - add/replace a HID quirk
* @id: the HID device to match
* @quirks: the unsigned long quirks value to add/replace
*
@@ -1069,7 +1069,7 @@ static struct hid_device_id *hid_exists_
* quirks value with what was provided. Otherwise, add the quirk
* to the dynamic quirks list.
*
- * Returns: 0 OK, -error on failure.
+ * Return: 0 OK, -error on failure.
*/
static int hid_modify_dquirk(const struct hid_device_id *id,
const unsigned long quirks)
@@ -1121,7 +1121,7 @@ static int hid_modify_dquirk(const struc
}
/**
- * hid_remove_all_dquirks: remove all runtime HID quirks from memory
+ * hid_remove_all_dquirks - remove all runtime HID quirks from memory
* @bus: bus to match against. Use HID_BUS_ANY if all need to be removed.
*
* Description:
@@ -1145,7 +1145,10 @@ static void hid_remove_all_dquirks(__u16
}
/**
- * hid_quirks_init: apply HID quirks specified at module load time
+ * hid_quirks_init - apply HID quirks specified at module load time
+ * @quirks_param: array of quirks strings (vendor:product:quirks)
+ * @bus: bus type
+ * @count: number of quirks to check
*/
int hid_quirks_init(char **quirks_param, __u16 bus, int count)
{
@@ -1176,7 +1179,7 @@ int hid_quirks_init(char **quirks_param,
EXPORT_SYMBOL_GPL(hid_quirks_init);
/**
- * hid_quirks_exit: release memory associated with dynamic_quirks
+ * hid_quirks_exit - release memory associated with dynamic_quirks
* @bus: a bus to match against
*
* Description:
@@ -1193,14 +1196,14 @@ void hid_quirks_exit(__u16 bus)
EXPORT_SYMBOL_GPL(hid_quirks_exit);
/**
- * hid_gets_squirk: return any static quirks for a HID device
+ * hid_gets_squirk - return any static quirks for a HID device
* @hdev: the HID device to match
*
* Description:
* Given a HID device, return a pointer to the quirked hid_device_id entry
* associated with that device.
*
- * Returns: the quirks.
+ * Return: the quirks.
*/
static unsigned long hid_gets_squirk(const struct hid_device *hdev)
{
@@ -1224,13 +1227,13 @@ static unsigned long hid_gets_squirk(con
}
/**
- * hid_lookup_quirk: return any quirks associated with a HID device
+ * hid_lookup_quirk - return any quirks associated with a HID device
* @hdev: the HID device to look for
*
* Description:
* Given a HID device, return any quirks associated with that device.
*
- * Returns: an unsigned long quirks value.
+ * Return: an unsigned long quirks value.
*/
unsigned long hid_lookup_quirk(const struct hid_device *hdev)
{
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2 v2] HID: fix some kernel-doc notations
2021-01-19 20:07 [PATCH 0/2 v2] HID: fix some kernel-doc notations Randy Dunlap
2021-01-19 20:07 ` [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h> Randy Dunlap
2021-01-19 20:07 ` [PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c Randy Dunlap
@ 2021-01-26 13:24 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2021-01-26 13:24 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Benjamin Tissoires, linux-input
On Tue, 19 Jan 2021, Randy Dunlap wrote:
> Clean up kernel-doc notation in 2 <linux/hid*.h> files
> and in drivers/hid/hid-quirks.c.
>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
>
> rebase & resend:
> [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h>
> [PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c
Applied, thanks Randy.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 20:07 [PATCH 0/2 v2] HID: fix some kernel-doc notations Randy Dunlap
2021-01-19 20:07 ` [PATCH 1/2 v2] HID: correct kernel-doc notation in <linux/hid*.h> Randy Dunlap
2021-01-19 20:07 ` [PATCH 2/2 v2] HID: correct kernel-doc notation in hid-quirks.c Randy Dunlap
2021-01-26 13:24 ` [PATCH 0/2 v2] HID: fix some kernel-doc notations Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).