From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
od@zcrc.me, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings/phy: ingenic: Add compatibles for?? JZ4760(B) SoCs
Date: Fri, 22 Jan 2021 10:06:43 -0600 [thread overview]
Message-ID: <20210122160643.GA865022@robh.at.kernel.org> (raw)
In-Reply-To: <SIBCNQ.SZL9QXM6XX3N2@crapouillou.net>
On Fri, Jan 22, 2021 at 02:42:28PM +0000, Paul Cercueil wrote:
> Hi Rob,
>
> Le ven. 22 janv. 2021 à 8:35, Rob Herring <robh+dt@kernel.org> a écrit :
> > On Wed, Jan 20, 2021 at 5:59 AM Paul Cercueil <paul@crapouillou.net>
> > wrote:
> > >
> > > Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible
> > > strings,
> > > and make the ingenic,jz4770-phy compatible string require
> > > ingenic,jz4760-phy as a fallback, since both work the same, and the
> > > JZ4760 SoC is older.
> > >
> > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > > ---
> > > .../bindings/phy/ingenic,phy-usb.yaml | 22
> > > ++++++++++++-------
> > > 1 file changed, 14 insertions(+), 8 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> > > b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> > > index 0fd93d71fe5a..3c65dfcf352b 100644
> > > --- a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> > > @@ -15,13 +15,19 @@ properties:
> > > pattern: '^usb-phy@.*'
> > >
> > > compatible:
> > > - enum:
> > > - - ingenic,jz4770-phy
> > > - - ingenic,jz4775-phy
> > > - - ingenic,jz4780-phy
> > > - - ingenic,x1000-phy
> > > - - ingenic,x1830-phy
> > > - - ingenic,x2000-phy
> > > + oneOf:
> > > + - enum:
> > > + - ingenic,jz4760-phy
> >
> > This should be 2 more spaces indentation. Indent is always 2 more than
> > the above keyword and ignores '-'.
>
> Pretty confusing. But alright.
TBC, either way is functional and these are the 2 main styles, so we
picked one. In some sequences, it's easy to miss a '-' where a space
would also be valid. For example:
items:
- items:
enum: ...
vs:
items:
items:
enum: ...
Both are valid (as items can be a list or sub-schema).
Rob
prev parent reply other threads:[~2021-01-22 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 11:59 [PATCH 1/2] dt-bindings/phy: ingenic: Add compatibles for JZ4760(B) SoCs Paul Cercueil
2021-01-20 11:59 ` [PATCH 2/2] phy: ingenic: Add support for the JZ4760 Paul Cercueil
2021-01-21 16:01 ` [PATCH 1/2] dt-bindings/phy: ingenic: Add compatibles for JZ4760(B) SoCs Rob Herring
2021-01-21 21:35 ` Paul Cercueil
2021-01-22 14:35 ` Rob Herring
2021-01-22 14:42 ` Paul Cercueil
2021-01-22 16:06 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122160643.GA865022@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).